Add test for direct get returning no responders #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Casper Beyer <casper@synadia.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive test case to verify the behavior of JetStream's direct get functionality when attempting to retrieve messages from non-existent streams. The test ensures that the appropriate error (NoRespondersError) is raised in various scenarios.
- Adds test for direct get operations on non-existent streams
- Verifies NoRespondersError is raised for different direct get variants
- Includes comparison with non-direct API behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Jarema
pushed a commit
that referenced
this pull request
Oct 30, 2025
* Add test for direct get returning no responders Signed-off-by: Casper Beyer <casper@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.