Skip to content

Fix StreamConfig omitempty fields for nats-server>2.12 #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix StreamConfig omitempty fields for nats-server>2.12 #788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions nats/tests/test_js.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3100,7 +3100,7 @@ async def error_handler(e):
assert config.template_owner == None

version = nc.connected_server_version
if version.major == 2 and version.minor < 9:
if version.major == 2 and (version.minor < 9 or version.minor > 12):
assert config.allow_direct == None
else:
assert config.allow_direct == False
Expand Down Expand Up @@ -4040,14 +4040,21 @@ async def error_handler(e):
assert sinfo.config.max_msgs == -1
assert sinfo.config.max_bytes == -1
assert sinfo.config.discard == "new"
assert sinfo.config.max_age == 0
version = nc.connected_server_version
if version.major == 2 and version.minor > 12:
assert sinfo.config.max_age is None
else:
assert sinfo.config.max_age == 0
assert sinfo.config.max_msgs_per_subject == -1
assert sinfo.config.max_msg_size == -1
assert sinfo.config.storage == "file"
assert sinfo.config.num_replicas == 1
assert sinfo.config.allow_rollup_hdrs == True
assert sinfo.config.allow_direct == True
assert sinfo.config.mirror_direct == False
if version.major == 2 and version.minor > 12:
assert sinfo.config.mirror_direct is None
else:
assert sinfo.config.mirror_direct == False

bucketname = "".join(random.SystemRandom().choice(string.ascii_letters) for _ in range(10))
obs = await js.create_object_store(bucket=bucketname)
Expand Down Expand Up @@ -4844,7 +4851,11 @@ async def test_stream_compression(self):
compression="none",
)
sinfo = await js.stream_info("NONE")
assert sinfo.config.compression == nats.js.api.StoreCompression.NONE
version = nc.connected_server_version
if version.major == 2 and version.minor > 12:
assert sinfo.config.compression is None
else:
assert sinfo.config.compression == nats.js.api.StoreCompression.NONE

# By default it should be using 'none' as the configured compression value.
js = nc.jetstream()
Expand All @@ -4853,7 +4864,10 @@ async def test_stream_compression(self):
subjects=["quux"],
)
sinfo = await js.stream_info("NONE2")
assert sinfo.config.compression == nats.js.api.StoreCompression.NONE
if version.major == 2 and version.minor > 12:
assert sinfo.config.compression is None
else:
assert sinfo.config.compression == nats.js.api.StoreCompression.NONE
await nc.close()

@async_test
Expand Down
Loading