Add rubocop-rspec_rails gem and enable HTTP status name consistency #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the rubocop-rspec_rails gem to provide Rails-specific RSpec linting. Enables the RSpecRails/HttpStatusNameConsistency cop to enforce using :unprocessable_content instead of the deprecated :unprocessable_entity for HTTP 422 status codes. Sets NewCops to disabled to prevent automatic enablement of new cops in future gem updates, allowing us to evaluate and enable them deliberately.
giverm
force-pushed
the
giverm/add-rubocop-rspec_rails-gem
branch
from
c3791b5 to
cac488a
Compare
nkutub
approved these changes
Nov 18, 2025
Contributor
|
@giverm is there any reason to not enable the other rspec cops from navapbc/oscer#29 in the Rails template? |
Contributor
Author
@doshitan Nope, that was my misreading of one of your comments on that PR. Your comment specific to not enabling new cops, but my thinking was we'd add and enable I can move the rest over the the template though. Let me know your preference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the rubocop-rspec_rails gem to provide Rails-specific RSpec linting.
Enables the RSpecRails/HttpStatusNameConsistency cop to enforce using :unprocessable_content instead of the deprecated :unprocessable_entity for HTTP 422 status codes.
Sets NewCops to disabled to prevent automatic enablement of new cops in future gem updates, allowing us to evaluate and enable them deliberately.