Fix parameter encoding #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kaetemi,
there is an issue where some characters in the parameters don't get encoded properly, causing the oauth signature to be invalid.
This package uses the
Uri.encodeComponent(param)to encode the params.Uri.encodeComponent(param)encodes all characters except letters, numbers and-_.!~*'().However the oauth1.0a specs define all characters except letters, numbers and
-_.~need to be percent-encoded (See https://oauth.net/core/1.0a/#encoding_parameters)In this PR I simply replaced all occurrences of the characters that are not accounted for in
Uri.encodeComponent(param)for with their percent encoded value.I also added a changelog and raised the version number.