Implement linters.one-resource-per-ns
#112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thumbnail
approved these changes
Jan 28, 2020
Member
thumbnail
left a comment
thumbnail
left a comment
There was a problem hiding this comment.
Looks great. Impressive to see the impact on key 👍
Comment on lines
+15
to
+17
| (is (= (sut/analyze "test/integration/formatting_stack/linters/one_resource_per_ns.clj") | ||
| ()))) | ||
|
|
Member
There was a problem hiding this comment.
what about (is (empty? (sut/analyze ...))) ?
Contributor
Author
There was a problem hiding this comment.
Dunno. Asserting values is more specific than asserting computations (not good to author tests that pass on many inputs - seems sloppy); and also seeing the actual output of given function seems pretty useful.
test/integration/formatting_stack/linters/one_resource_per_ns.clj
Outdated
Show resolved
Hide resolved
vemv
force-pushed
the
78--one-resource-per-ns
branch
from
3c45222 to
6f1f783
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief
Fixes #78 (at least partially; I extracted an extended use case to #113)
QA plan
Author checklist
Reviewer checklist