Skip to content

perf: move some responsibilities out of recursive function #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 26, 2022
Merged

perf: move some responsibilities out of recursive function #17

merged 4 commits into from
Jul 26, 2022

Conversation

@neefrehman
Copy link
Owner

@neefrehman neefrehman commented Jul 26, 2022 •
edited
Loading

  • restructures parent and child responsibilities, to narrow the internal function's set of concerns, reduce the count of some checks, and reduce bundle size
  • drops custom integer validation in favour of inbuilt js array length checks

@neefrehman
perf: move checks out of recursive function call
e4179f5 
restructures responsibilities to the reduce count of some checks

improves performance and reduce bundle size
@neefrehman
perf(validation): drop custom integer validation
c506817 
drops integer validation in favour of inbuilt js array length checks
@github-actions
Copy link

github-actions bot commented Jul 26, 2022

Benchmark against currently published version:

Key Current PR Published version Difference
nDimensions 8,142 ops/s 10,238 ops/s 🚨 -20.47% slower
specificDimensions 99,879 ops/s 85,087 ops/s ✅ 17.38% faster
specific & callback 19,990 ops/s 16,679 ops/s ✅ 19.85% faster
Average ✅ 5.59% faster

@neefrehman neefrehman changed the title responsibilities restructure perf: move some responsibilities out of recursive function Jul 26, 2022
@github-actions
Copy link

github-actions bot commented Jul 26, 2022

Benchmark against currently published version:

Key Current PR Published version Difference
nDimensions 8,122 ops/s 10,238 ops/s 🚨 -20.67% slower
specificDimensions 104,730 ops/s 85,087 ops/s ✅ 23.09% faster
specific & callback 22,797 ops/s 16,679 ops/s ✅ 36.68% faster
Average ✅ 13.03% faster

@github-actions
Copy link

github-actions bot commented Jul 26, 2022

Benchmark against currently published version:

Key Current PR Published version Difference
nDimensions 8,244 ops/s 10,238 ops/s 🚨 -19.48% slower
specificDimensions 108,206 ops/s 85,087 ops/s ✅ 27.17% faster
specific & callback 19,394 ops/s 16,679 ops/s ✅ 16.28% faster
Average ✅ 7.99% faster

@neefrehman neefrehman merged commit 90cd625 into main Jul 26, 2022
@neefrehman neefrehman deleted the responsibilities_restructure branch July 26, 2022 14:15
github-actions bot pushed a commit that referenced this pull request Jul 26, 2022
@semantic-release-bot
chore(release): 2.1.5 [skip ci]
39080eb 
## [2.1.5](v2.1.4...v2.1.5) (2022-07-26)

### Performance Improvements

* move some responsibilities out of recursive function ([#17](#17)) ([90cd625](90cd625))
@github-actions
Copy link

github-actions bot commented Jul 26, 2022

🎉 This PR is included in version 2.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@neefrehman