Skip to content

perf: move some responsibilities out of recursive function #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 26, 2022
Merged

perf: move some responsibilities out of recursive function #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4179f5
perf: move checks out of recursive function call
neefrehman Jul 26, 2022
c506817
perf(validation): drop custom integer validation
neefrehman Jul 26, 2022
93cd53d
refactor: rename variable for clarity
neefrehman Jul 26, 2022
75c369a
refactor: refactor top-level conditional
neefrehman Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/setup-node-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ jobs:
run: npm run build
- name: validate build
run: |
FILE=lib/index.js
FILE2=lib/index.d.ts
if [ -f $FILE ] && [ -f $FILE2 ]; then echo "Files exist"
else echo "Files do not exist" && exit 1
fi
FILE=lib/index.js
FILE2=lib/index.d.ts
if [ -f $FILE ] && [ -f $FILE2 ]; then echo "Files exist"
else echo "Files do not exist" && exit 1
fi
- name: lint
run: npm run lint
- name: test
Expand All @@ -68,4 +68,4 @@ jobs:
id: benchmark
run: npm run benchmark:diff:ci
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5 changes: 2 additions & 3 deletions benchmark/run-benchmark.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ benny
["new", "old", "delta"]
);

if (!isInCI) {
if (!isInCI || !process.env.GITHUB_TOKEN) {
return;
}

Expand All @@ -89,8 +89,7 @@ benny
body += `| ${diff.name} | ${diff.new}| ${diff.old} | ${diff.delta} |\n`;
});

const octokit = getOctokit(process.env.GITHUB_TOKEN ?? "");
await octokit.rest.issues.createComment({
await getOctokit(process.env.GITHUB_TOKEN).rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
Expand Down
Loading