-
Notifications
You must be signed in to change notification settings - Fork 57
Catbuffer applied on Schemas and Buffers generation #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appended new signwithCatbuffer method in Transaction (temp) Applied catbuffer builders on standalone transaction (builder) Updated unit tests
Model field name updates
Appended new signwithCatbuffer method in Transaction (temp) Applied catbuffer builders on standalone transaction (builder) Updated unit tests
…avascript into ts-catbuffer
….com:rg911/nem2-sdk-typescript-javascript into task/g218_block_outgoing_account_restriction
- createTransactionFromPayload now use catbuffer
Appended new signwithCatbuffer method in Transaction (temp) Applied catbuffer builders on standalone transaction (builder) Updated unit tests
- createTransactionFromPayload now use catbuffer
- Catbuffer use separate builder class for Complete and Bonded - Added unit tests
Appended new signwithCatbuffer method in Transaction (temp) Applied catbuffer builders on standalone transaction (builder) Updated unit tests
Appended new signwithCatbuffer method in Transaction (temp) Applied catbuffer builders on standalone transaction (builder) Updated unit tests
- createTransactionFromPayload now use catbuffer
…avascript into ts-catbuffer
evias
approved these changes
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catbuffer
Catbuffer
Typescript Generatorhas been developed currently under reviewing. Opening PR can be found here. All schemas defined in Catbuffer can be generated by this generator exceptAggregateTransaction,CosignatureandDetachedCosignature. Those schemas are currently manually created. Development is undergoing to patch the generator to support them.Catbuffer implementation (In this PR)
Removed Flatbuffer codes:
Transaction builder,schema,buffer codesAdded generated Typescript catbuffer codes.
Manually patched
AggregateTransaction,CosignatureandDetachedCosignatureschemasRefactored
signWith()and added two abstract methods:generateBytes(),generateEmbeddedBytes()inTransaction.ts.Refactored all transaction models added
generateBytes(),generateEmbeddedBytes()using catbuffer generated classes.Refactored all
Cosignatoriessigning methods inAggregateTransaction.tsandCosignatureTransaction.tsUpdated some models to match the latest catbuffer schema.
Patched the unit tests and e2e tests
Refactored
TransactionMapping.CreateTransactionFromPayload()to use catbuffer.Breaking changes:
Durationis now required. **For defining eternal mosaic, useUint64.fromUint(0)Add = 0x00=>Add = 0x01LinkAction,MultisigCosignatoryModificationType,AliasAction,MosaicSupplyType,RestrictionModificationType (AccountRestriction)Issue: #92