Added merkle hash calculation for block transactions #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rg911
commented
Oct 9, 2020
rg911
commented
- Fixed BLS Voting key generation #620
- Added merkle hash calculation for block transactions
rg911
force-pushed
the
task/g620_block_transaction_merkle
branch
from
5261318 to
c17558a
Compare
fboucquez
suggested changes
Oct 9, 2020
Contributor
fboucquez
left a comment
fboucquez
left a comment
There was a problem hiding this comment.
Also add an e2e test validating that server resolves the same hash. I'll copy the implementation over to java :)
- fixed some bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.