Skip to content

Conversation

@Lojjs
Copy link
Contributor

@Lojjs Lojjs commented Oct 7, 2022

Fixes

Startup log exception in Neo4j 5.x about 'Topology Graph is not initialized yet'

Proposed Changes (Mandatory)

  • Check compatibility on the system database instead of the default database
  • Make sure dbms.components() has been registered
  • Update compatibility warning message to apply to 5.x versioning

…database.

In 5.x, Neo4j will warn about 'Topology Graph is not initialized yet' on startup otherwise.

Also make sure dbms.components() has been registered and update warning message for 5.x.
@Lojjs Lojjs force-pushed the dev-fix-compatibility-check branch from b284441 to 6223d39 Compare October 10, 2022 05:55
@gem-neo4j gem-neo4j self-assigned this Oct 10, 2022
userLog.warn("The apoc version (%s) and the Neo4j DBMS versions %s are incompatible. \n" +
"See the compatibility matrix in https://neo4j.com/labs/apoc/4.4/installation/ to see the correct version",
apocFullVersion, versions.toString());
"The two first numbers of both versions needs to be the same.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true? I thought after 5.0 we wanted to have a compatibility layer that works differently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me, Nacho and Daniel discussed this a bit at the lunch lecture on GDS compatibility layer last week. It is leaning towards that we will not do a compatibility layer, but just say you need to use e.g. APOC 5.2.0 with Neo4j 5.2.0 or Neo4j 5.2.1 (if there is a security patch)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay :)

Copy link
Contributor

@gem-neo4j gem-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the only thing I can think of that might be useful is to add a comment to explain why this works as I was confused :P But that is up to you :)

@Lojjs Lojjs merged commit 7838525 into dev Oct 11, 2022
@Lojjs Lojjs deleted the dev-fix-compatibility-check branch October 11, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants