Skip to content

Mark legacy relationship types as deprecated. #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2022
Merged

Mark legacy relationship types as deprecated. #177

merged 1 commit into from
Nov 24, 2022

Conversation

@arnefischereit
Copy link
Contributor

@arnefischereit arnefischereit commented Nov 10, 2022

No description provided.

@arnefischereit arnefischereit added deprecated Syntax or feature has been deprecated (Only label the specific version that introduced this)) team-cypher-planner 5.0 Neo4j version 5.0 labels Nov 10, 2022
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Nov 10, 2022

Looks like you've updated the documentation!

Check out your changes at https://neo4j-docs-cypher-177.surge.sh

@arnefischereit arnefischereit added cherry-pick-this-to-5.x Cherry pick this PR changes to the 5.x branch and removed 5.0 Neo4j version 5.0 labels Nov 10, 2022
LinneaAndersson
LinneaAndersson reviewed Nov 14, 2022
View reviewed changes
modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc Outdated

The function `elementId` returns an ID for the given input value (node or relationship).


Copy link
Contributor

@LinneaAndersson LinneaAndersson Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should put it on the top of the list of deprecations? It feels like newer deprecations should go on the top, but I'm not sure. What do you think?

Copy link
Contributor Author

@arnefischereit arnefischereit Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on this.
For every new version when we deprecate something new, it should be placed in its own section for the new version, so the order should not matter that much as they are introduced to the user "at the same time". This on the other hand is retro-actively adding a deprecation to a version which was already there.

Therefore, do you think it matters where this is placed?

Copy link
Contributor

@LinneaAndersson LinneaAndersson Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, true. Then it doesn't matter

LinneaAndersson
LinneaAndersson approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@LinneaAndersson LinneaAndersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JPryce-Aklundh JPryce-Aklundh merged commit f9009a2 into neo4j:dev Nov 24, 2022
@JPryce-Aklundh JPryce-Aklundh deleted the deprecate-legacy-rel-types branch November 24, 2022 13:00
@JPryce-Aklundh JPryce-Aklundh mentioned this pull request Nov 24, 2022
Merged
JPryce-Aklundh added a commit that referenced this pull request Nov 24, 2022
@JPryce-Aklundh
Mark legacy relationship types as deprecated. (#232)
d95bebc 
Original PR: #177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LinneaAndersson LinneaAndersson LinneaAndersson approved these changes

Assignees

@LinneaAndersson LinneaAndersson

Labels

cherry-pick-this-to-5.x Cherry pick this PR changes to the 5.x branch deprecated Syntax or feature has been deprecated (Only label the specific version that introduced this)) team-cypher-planner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arnefischereit @neo-technology-commit-status-publisher @LinneaAndersson @JPryce-Aklundh