Skip to content

Conversation

@Hunterness
Copy link
Collaborator

@Hunterness Hunterness commented Nov 22, 2022

Feature merged in 5.3 but hidden behind feature flag so documentation should probably not be merged until that is removed, flag turned true by default in https://github.com/neo-technology/neo4j/pull/18469, so can go in once that is merged. Feature flag has been merged and is turned on from 5.4.

Also added to the cheat sheet here (also updates links): https://github.com/neo4j/docs-cheat-sheet/pull/40
And updates links in operations manual here: neo4j/docs-operations#175

@Hunterness Hunterness added new New syntax or feature (Only label the specific version that introduced this) team-cypher-operations Cypher operations should review this labels Nov 22, 2022
@neo-technology-commit-status-publisher
Copy link
Collaborator

Looks like you've updated the documentation!

Check out your changes at https://neo4j-docs-cypher-225.surge.sh

Copy link
Contributor

@l-heemann l-heemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we have copied over wierd choices from the node constraints section into the relationship constraints section. This is probably not the PR/task for cleaning up existing documentation, so maybe we should leave that as a separate task?

I have added comments on the parts that stuck out the most in the new section.

Copy link
Contributor

@l-heemann l-heemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@emmaholmbergohlsson emmaholmbergohlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just spotted a small thing

@Hunterness Hunterness force-pushed the 5.3-relationship-constraints branch from e0dbe70 to 4bae968 Compare December 6, 2022 08:29
@Hunterness Hunterness force-pushed the 5.3-relationship-constraints branch 2 times, most recently from a146d9d to 5072886 Compare December 20, 2022 13:27
Copy link
Collaborator

@JPryce-Aklundh JPryce-Aklundh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Hunterness Hunterness added the 5.4 label Dec 21, 2022
@Hunterness Hunterness force-pushed the 5.3-relationship-constraints branch from 5072886 to 0a6e270 Compare December 21, 2022 14:53
@Hunterness Hunterness marked this pull request as ready for review December 21, 2022 14:53
@Hunterness Hunterness force-pushed the 5.3-relationship-constraints branch from 0a6e270 to 0b72db8 Compare January 4, 2023 09:33
@Hunterness Hunterness merged commit dd6fb31 into neo4j:dev Jan 4, 2023
recrwplay pushed a commit that referenced this pull request Jan 25, 2023
Feature merged in 5.3 but hidden behind feature flag, the flag was turned true by default in 5.4.
lidiazuin pushed a commit to lidiazuin/docs-cypher that referenced this pull request May 21, 2025
Feature merged in 5.3 but hidden behind feature flag, the flag was turned true by default in 5.4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.4 Dependencies w. other PR new New syntax or feature (Only label the specific version that introduced this) team-cypher-operations Cypher operations should review this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants