-
Notifications
You must be signed in to change notification settings - Fork 64
Document relationship key and uniqueness constraints #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document relationship key and uniqueness constraints #225
Conversation
|
Looks like you've updated the documentation! Check out your changes at https://neo4j-docs-cypher-225.surge.sh |
l-heemann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we have copied over wierd choices from the node constraints section into the relationship constraints section. This is probably not the PR/task for cleaning up existing documentation, so maybe we should leave that as a separate task?
I have added comments on the parts that stuck out the most in the new section.
d5e6edb to
d10ac4a
Compare
l-heemann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
emmaholmbergohlsson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just spotted a small thing
e0dbe70 to
4bae968
Compare
2c206d6 to
1a0c0bb
Compare
modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc
Outdated
Show resolved
Hide resolved
a146d9d to
5072886
Compare
JPryce-Aklundh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
5072886 to
0a6e270
Compare
and also allowing `UNIQUENESS` for the type filtering in `SHOW UNIQUE CONSTRAINTS`
It was a mix of uniqueness, unique and unique property
Also remove 2 places referencing the now removed `db.indexes` and `db.constraints` procedures
…raints after discussion with Valerio and Emma
Co-authored-by: Jens Pryce-Åklundh <112686610+JPryce-Aklundh@users.noreply.github.com>
0a6e270 to
0b72db8
Compare
Feature merged in 5.3 but hidden behind feature flag, the flag was turned true by default in 5.4.
Feature merged in 5.3 but hidden behind feature flag, the flag was turned true by default in 5.4.
Feature merged in 5.3 but hidden behind feature flag so documentation should probably not be merged until that is removed, flag turned true by default in https://github.com/neo-technology/neo4j/pull/18469, so can go in once that is merged. Feature flag has been merged and is turned on from 5.4.
Also added to the cheat sheet here (also updates links): https://github.com/neo4j/docs-cheat-sheet/pull/40
And updates links in operations manual here: neo4j/docs-operations#175