Skip to content

Editorial review of built-in-roles.adoc + matching formatting #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2022
Merged

Editorial review of built-in-roles.adoc + matching formatting #31

merged 1 commit into from
Jul 26, 2022

Conversation

@lidiazuin
Copy link
Contributor

@lidiazuin lidiazuin commented Jul 26, 2022

@lidiazuin lidiazuin added the 4.4 Neo4j version 4.4 label Jul 26, 2022
@netlify
Copy link

netlify bot commented Jul 26, 2022

✅ Deploy Preview for neo4j-docs-cypher ready!

Name Link
🔨 Latest commit 36697e2
🔍 Latest deploy log https://app.netlify.com/sites/neo4j-docs-cypher/deploys/62dfc491e9ea3d0008002059
😎 Deploy Preview https://deploy-preview-31--neo4j-docs-cypher.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

martin-neotech
martin-neotech approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@martin-neotech martin-neotech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

This is a nice PR, not to huge and easy to review.

Then dont forget to write a greate merge commit text like:

Editorial improvements for the built in roles page in the access-control section.

@martin-neotech martin-neotech added cherry-pick-this-to-5.x Cherry pick this PR changes to the 5.x branch improvements Improved the text or examples labels Jul 26, 2022
@lidiazuin lidiazuin changed the title merging editorial review of access control with correct formatting Editorial review of built-in-roles.adoc + matching formatting Jul 26, 2022
@lidiazuin lidiazuin mentioned this pull request Jul 26, 2022
Closed
@martin-neotech martin-neotech merged commit 28993c8 into neo4j:4.4 Jul 26, 2022
martin-neotech added a commit that referenced this pull request Jul 26, 2022
@martin-neotech @lidiazuin
Editorial review of the built in roles for access control section (#31)…
e545776 
… (#41)

Editorial improvements for the built in roles page in the access-control section.

Co-authored-by: lidiazuin <102308961+lidiazuin@users.noreply.github.com>
@lidiazuin lidiazuin removed the cherry-pick-this-to-5.x Cherry pick this PR changes to the 5.x branch label Jul 27, 2022
@lidiazuin lidiazuin added the cherry-pick-this-to-5.x Cherry pick this PR changes to the 5.x branch label Oct 10, 2022
@lidiazuin lidiazuin mentioned this pull request Oct 10, 2022
Merged
@lidiazuin lidiazuin deleted the 4.4-builtinrolesrvw branch October 10, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@martin-neotech martin-neotech martin-neotech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4.4 Neo4j version 4.4 cherry-pick-this-to-5.x Cherry pick this PR changes to the 5.x branch improvements Improved the text or examples

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lidiazuin @martin-neotech