Skip to content

Deprecate connectComponentsPlanner #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2023
Merged

Deprecate connectComponentsPlanner #468

merged 3 commits into from
Mar 22, 2023

Conversation

@sherfert
Copy link
Contributor

@sherfert sherfert commented Mar 9, 2023

No description provided.

@sherfert sherfert added deprecated Syntax or feature has been deprecated (Only label the specific version that introduced this)) team-cypher-planner dev 5.7 labels Mar 9, 2023
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Mar 9, 2023

Looks like you've updated the documentation!

Check out your changes at https://neo4j-docs-cypher-468.surge.sh

AzuObs
AzuObs reviewed Mar 10, 2023
View reviewed changes
modules/ROOT/pages/query-tuning/query-options.adoc

[[cypher-connect-components-planner]]
== Cypher connect-components planner
== Cypher connect-components planner label:deprecated[]
Copy link
Contributor

@AzuObs AzuObs Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-03-10 at 09 16 29

The rendering is perhaps a little weird but I'm not sure that's something you can easily solve

Copy link
Contributor

@arnefischereit arnefischereit Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that is a general problem in the docs at the moment.
We had some similar issues with code environments when discussing the new manual's structure with @JPryce-Aklundh .

Copy link
Collaborator

@JPryce-Aklundh JPryce-Aklundh Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently having some trouble with the ui-bundle. I will bring this example to the team and hopefully we will have a fix soon.

AzuObs
AzuObs approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@AzuObs AzuObs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM 👍 Thanks for making the change

JPryce-Aklundh
JPryce-Aklundh approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@JPryce-Aklundh JPryce-Aklundh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍
docs-dev currently targets 5.6, however, so I will wait with merging until it targets 5.7.

@JPryce-Aklundh JPryce-Aklundh merged commit bf3ade4 into neo4j:dev Mar 22, 2023
@JPryce-Aklundh JPryce-Aklundh deleted the deprecate-ccp branch March 22, 2023 09:58
JPryce-Aklundh pushed a commit to JPryce-Aklundh/docs-cypher that referenced this pull request Apr 20, 2023
@sherfert @JPryce-Aklundh
Deprecate connectComponentsPlanner (neo4j#468)
96a733d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arnefischereit arnefischereit arnefischereit left review comments

@JPryce-Aklundh JPryce-Aklundh JPryce-Aklundh approved these changes

+1 more reviewer

@AzuObs AzuObs AzuObs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AzuObs AzuObs

Labels

5.7 deprecated Syntax or feature has been deprecated (Only label the specific version that introduced this)) dev team-cypher-planner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sherfert @neo-technology-commit-status-publisher @AzuObs @arnefischereit @JPryce-Aklundh