document allowed whitespace characters #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

davidoliverSP2 merged 5 commits into neo4j:dev from nadja-muller:dev-document-whitespaces

May 16, 2023

Contributor

nadja-muller commented May 2, 2023

No description provided.

nadja-muller added team-cypher-surface 5.8 labels

Collaborator

neo-technology-commit-status-publisher commented May 2, 2023

Looks like you've updated the documentation!

Check out your changes at https://neo4j-docs-cypher-531.surge.sh

Lojjs assigned ncordon

ncordon reviewed

View reviewed changes

modules/ROOT/pages/syntax/parsing.adoc Outdated Show resolved Hide resolved

ncordon reviewed

View reviewed changes

modules/ROOT/pages/syntax/parsing.adoc Outdated Show resolved Hide resolved

ncordon reviewed

View reviewed changes

modules/ROOT/pages/syntax/parsing.adoc Outdated Show resolved Hide resolved

ncordon reviewed

View reviewed changes

modules/ROOT/pages/syntax/parsing.adoc Outdated Show resolved Hide resolved

ncordon suggested changes

View reviewed changes

Contributor

ncordon left a comment •

edited

Loading

Could we request a review of docs team before merging this please?

The parsing section does not seem to appear in the TOC?

Collaborator

JPryce-Aklundh commented May 11, 2023

@ncordon - the conflict is a result of the newly published, stand-alone (as in, no longer within the Syntax chapter) chapter about Values and types (https://neo4j.com/docs/cypher-manual/current/values-and-types/).

nadja-muller force-pushed the dev-document-whitespaces branch from 61a843e to 88adeaa Compare

May 12, 2023 17:48

nadja-muller requested review from JPryce-Aklundh and ncordon

May 12, 2023 19:22

ncordon reviewed

View reviewed changes

modules/ROOT/pages/syntax/parsing.adoc Outdated Show resolved Hide resolved

ncordon reviewed

View reviewed changes

modules/ROOT/pages/syntax/parsing.adoc Show resolved Hide resolved

ncordon reviewed

View reviewed changes

modules/ROOT/pages/syntax/parsing.adoc Outdated Show resolved Hide resolved

ncordon approved these changes

View reviewed changes

nadja-muller and others added 4 commits

May 16, 2023 17:33


          document allowed whitespace characters

e7d7a7e


          fix grammar

Co-authored-by: Nacho Cordón <ncordon@users.noreply.github.com>


          improve general description and add examples

03715ac


          Update modules/ROOT/pages/syntax/parsing.adoc

12b41f1

Co-authored-by: Nacho Cordón <ncordon@users.noreply.github.com>

nadja-muller force-pushed the dev-document-whitespaces branch from 818e86b to 12b41f1 Compare

May 16, 2023 15:33

davidoliverSP2 added the cherry-pick-this-to-5.x label


          Editorial updates

f1f2ae8

davidoliverSP2 approved these changes

View reviewed changes

Contributor

davidoliverSP2 left a comment

Thanks everyone - I managed to resolve the issue whereby the new page wasn't building. I pushed some minor editorial changes also.

davidoliverSP2 merged commit 5e427a9 into neo4j:dev

davidoliverSP2 added a commit to davidoliverSP2/docs-cypher that referenced this pull request


          document allowed whitespace characters (neo4j#531)

4f7fadd

Co-authored-by: Nacho Cordón <ncordon@users.noreply.github.com>
Co-authored-by: David Oliver <david.oliver@neo4j.com>

davidoliverSP2 added a commit that referenced this pull request


          document allowed whitespace characters (#531) (#562)

b818233

Co-authored-by: Nadja Müller <73830555+nadja-muller@users.noreply.github.com>
Co-authored-by: Nacho Cordón <ncordon@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.8 cherry-pick-this-to-5.x team-cypher-surface