Skip to content

Add NODES 23 ad #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2023
Merged

Add NODES 23 ad #561

merged 2 commits into from
May 17, 2023

Conversation

@recrwplay
Copy link
Contributor

@recrwplay recrwplay commented May 16, 2023

No description provided.

@recrwplay recrwplay added the 5.x Applies to all Neo4j 5 docs label May 16, 2023
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented May 16, 2023

Looks like you've updated the documentation!

Check out your changes at https://neo4j-docs-cypher-561.surge.sh

@recrwplay recrwplay requested a review from davidoliverSP2 May 16, 2023 16:14
@davidoliverSP2
Copy link
Contributor

davidoliverSP2 commented May 16, 2023

@recrwplay the surge link (+ local builds) doesn't pick up the ad - should it? (could this PR depend on another in in the UI repo?)

@recrwplay
Copy link
Contributor Author

recrwplay commented May 16, 2023

I added it to the publish.yml playbook only, and the checks here use preview.yml. You could test it locally by building with the publish playbook, but you'd also need to update the source branches in that playbook, replacing 5.x with HEAD

davidoliverSP2
davidoliverSP2 approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@davidoliverSP2 davidoliverSP2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @recrwplay 👍

Lets add a reminder to remove this on the 27th Oct!

@recrwplay recrwplay merged commit 9b3badf into neo4j:5.x May 17, 2023
@recrwplay recrwplay deleted the nodes-23 branch May 17, 2023 12:05
lidiazuin pushed a commit to lidiazuin/docs-cypher that referenced this pull request May 21, 2025
@recrwplay @lidiazuin
Add NODES 23 ad (neo4j#561)
bc8a197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidoliverSP2 davidoliverSP2 davidoliverSP2 approved these changes

Assignees

No one assigned

Labels

5.x Applies to all Neo4j 5 docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@recrwplay @neo-technology-commit-status-publisher @davidoliverSP2