Skip to content

Udate metrics according to the test results #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 24, 2023
Merged

Udate metrics according to the test results #1195

merged 4 commits into from
Nov 24, 2023

Conversation

@NataliaIvakina
Copy link
Collaborator

@NataliaIvakina NataliaIvakina commented Nov 22, 2023 •
edited
Loading

In terms of our testing project, update the metrics, their classes and descriptions. All changes are made according to the file metrics_without_descriptions.txt

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Nov 22, 2023 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

NataliaIvakina
NataliaIvakina commented Nov 22, 2023
View reviewed changes
@NataliaIvakina
Copy link
Collaborator Author

I haven't found any clues which metrics could be included in class Lighthouse metrics.

renetapopova
renetapopova reviewed Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all looks good. I just added two comments. Could you also check that all captions are sentence case, for example, .CatchUp Metrics should be .Catchup metrics.

NataliaIvakina
NataliaIvakina commented Nov 23, 2023
View reviewed changes
renetapopova
renetapopova approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, @NataliaIvakina

@NataliaIvakina NataliaIvakina merged commit 7dad212 into neo4j:dev Nov 24, 2023
@NataliaIvakina NataliaIvakina deleted the dev-metrics-update branch November 24, 2023 15:06
NataliaIvakina added a commit to NataliaIvakina/docs-operations that referenced this pull request Nov 24, 2023
@NataliaIvakina
Udate metrics according to the test results (neo4j#1195)
beed6b4 
In terms of our testing project, update the metrics, their classes and
descriptions. All changes are made according to the file
_metrics_without_descriptions.txt_
NataliaIvakina added a commit that referenced this pull request Nov 24, 2023
@NataliaIvakina
Udate metrics according to the test results (#1195) (#1205)
3334e79 
In terms of our testing project, update the metrics, their classes and
descriptions. All changes are made according to the file
_metrics_without_descriptions.txt_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renetapopova renetapopova renetapopova approved these changes

Assignees

No one assigned

Labels

cherry-pick-this-to-5.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NataliaIvakina @neo-technology-commit-status-publisher @renetapopova