Rename Neo4j connectors to network connectors to differentiate them from Kafka, Spark, etc. #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
mauvo
reviewed
Jan 4, 2024
|
|
||
| The connectors are configured by settings on the format `server.<connector-name>.<setting-suffix>>`. | ||
| The available suffixes are described in the table below: | ||
| The network connectors are configured by settings on the format `server.<network-connector-name>.<setting-suffix>>`. |
There was a problem hiding this comment.
I think it should say: in the format
There was a problem hiding this comment.
yes, good spot
mauvo
reviewed
Jan 4, 2024
| It is possible to specify defaults for the configuration options with `listen_address` and `advertised_address` suffixes, as described below. | ||
| Setting a default value will apply to all the connectors, unless specifically configured for a certain connector. | ||
| It is possible to specify defaults for the configuration options with `listen_address` and `advertised_address` suffixes. | ||
| Setting a default value applies to all network connectors unless specifically configured for a certain connector. |
There was a problem hiding this comment.
Should be something like:
If a default value is set, it will apply to all
or
Default value are applied to all
There was a problem hiding this comment.
I haven't edited the text. I just fixed the future tense here, as this is how it works.
mauvo
approved these changes
Jan 4, 2024
Thanks for the quick response, @mauvo! I'll fix the first one and leave the second one as it is if you don't have a strong opinion about it. |
renetapopova
added a commit
to renetapopova/docs-operations
that referenced
this pull request
Jan 4, 2024
…rom Kafka, Spark, etc. (neo4j#1301)
NataliaIvakina
added a commit
that referenced
this pull request
Jan 17, 2024
Rename the section title according to the recent changes in page _Configure network connectors_. See PR #1301
NataliaIvakina
added a commit
to NataliaIvakina/docs-operations
that referenced
this pull request
Jan 17, 2024
Rename the section title according to the recent changes in page _Configure network connectors_. See PR neo4j#1301
NataliaIvakina
added a commit
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.