Add section on limitations around privileges and missing labels #1453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as well as notes on the relevant privileges linking to it.
Hunterness
commented
Feb 28, 2024
modules/ROOT/pages/authentication-authorization/privileges-reads.adoc
Outdated
Show resolved
Hide resolved
HannesSandberg
requested changes
Mar 1, 2024
modules/ROOT/pages/authentication-authorization/limitations.adoc
Outdated
Show resolved
Hide resolved
HannesSandberg
approved these changes
Mar 4, 2024
renetapopova
requested changes
Mar 5, 2024
There was a problem hiding this comment.
I tried to simplify the language, but I might need to review the PR again after you review the suggestions. Also, I am still trying to figure out the example. Do we want to give an example of a failure and then a workaround, or maybe we can show how to do it properly to avoid getting the error?
modules/ROOT/pages/authentication-authorization/limitations.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/limitations.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/limitations.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/limitations.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/limitations.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/limitations.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/privileges-reads.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/privileges-reads.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/privileges-reads.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/privileges-writes.adoc
Outdated
Show resolved
Hide resolved
I think showing the weird behaviour in the Limitations section is useful, it is after all that behaviour we have gotten questions about so we need to at least tell 'if this is what happens, then this is why' so it makes sense to me for the example to show that |
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
renetapopova
reviewed
Mar 5, 2024
modules/ROOT/pages/authentication-authorization/limitations.adoc
Outdated
Show resolved
Hide resolved
renetapopova
reviewed
Mar 5, 2024
modules/ROOT/pages/authentication-authorization/limitations.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
renetapopova
reviewed
Mar 5, 2024
There was a problem hiding this comment.
A few more suggestions. Otherwise, I think it looks good. Thanks, @Hunterness!
modules/ROOT/pages/authentication-authorization/limitations.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/limitations.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/limitations.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Therese Magnusson <scout.therese@gmail.com>
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
renetapopova
approved these changes
Mar 6, 2024
renetapopova
added a commit
to renetapopova/docs-operations
that referenced
this pull request
Mar 6, 2024
…j#1453) as well as notes on the relevant privileges linking to it --------- Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
renetapopova
added
cherry-pick-this-to-5.x
and removed
dev
cherry-pick-this-backward
labels
renetapopova
added a commit
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as well as notes on the relevant privileges linking to it