Skip to content

Added lighthouse public settings #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 28, 2024
Merged

Added lighthouse public settings #1693

merged 11 commits into from
Jun 28, 2024

Conversation

@akarasavov
Copy link
Contributor

@akarasavov akarasavov commented Jun 25, 2024 •
edited
Loading

@NataliaIvakina
Copy link
Collaborator

In what version do they become visible? 5.22?

@NataliaIvakina NataliaIvakina self-assigned this Jun 25, 2024
NataliaIvakina
NataliaIvakina reviewed Jun 25, 2024
View reviewed changes
yirensum
yirensum reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@yirensum yirensum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side too

@akarasavov
Copy link
Contributor Author

In what version do they become visible? 5.22?

They are already visible

In what version do they become visible? 5.22?

Yes, you are right. Those settings will become available in 5.22

akarasavov and others added 2 commits June 27, 2024 09:57
@akarasavov @NataliaIvakina
Update modules/ROOT/pages/configuration/configuration-settings.adoc
c814cb4 
Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com>
@akarasavov @NataliaIvakina
Update modules/ROOT/pages/configuration/configuration-settings.adoc
fcd96f8 
Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com>
@renetapopova renetapopova self-requested a review June 27, 2024 09:28
renetapopova
renetapopova requested changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The descriptions are very well-written according to our style. However, in the codebase, they are entirely different. I added some comments mainly related to the fact that they should be the same in the codebase.

akarasavov and others added 2 commits June 27, 2024 11:22
@akarasavov @renetapopova
Update modules/ROOT/pages/configuration/configuration-settings.adoc
ef32245 
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
@akarasavov @renetapopova
Update modules/ROOT/pages/configuration/configuration-settings.adoc
55d71ed 
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
recrwplay
recrwplay reviewed Jun 27, 2024
View reviewed changes
NataliaIvakina
NataliaIvakina reviewed Jun 27, 2024
View reviewed changes
NataliaIvakina and others added 3 commits June 27, 2024 15:55
@NataliaIvakina @recrwplay
Apply suggestions from code review
3a560ca 
Co-authored-by: Neil Dewhurst <neil.dewhurst@neo4j.com>
@akarasavov @renetapopova
Update modules/ROOT/pages/configuration/configuration-settings.adoc
76d5813 
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
@akarasavov
Update description of dbms.cluster.discovery.endpoints
580bc20
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Jun 28, 2024 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@akarasavov akarasavov requested a review from renetapopova June 28, 2024 10:22
renetapopova
renetapopova approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @akarasavov!

@renetapopova renetapopova merged commit ae1b405 into dev Jun 28, 2024
@renetapopova renetapopova deleted the update_lighthouse_settings branch June 28, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@recrwplay recrwplay recrwplay left review comments

@NataliaIvakina NataliaIvakina NataliaIvakina left review comments

@yirensum yirensum yirensum left review comments

@renetapopova renetapopova renetapopova approved these changes

Assignees

@NataliaIvakina NataliaIvakina

@yirensum yirensum

Labels

5.22 clustering

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@akarasavov @NataliaIvakina @neo-technology-commit-status-publisher @renetapopova @recrwplay @yirensum