Skip to content

Describe new lighthouse procedures #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 1, 2024
Merged

Describe new lighthouse procedures #1694

merged 10 commits into from
Jul 1, 2024

Conversation

@akarasavov
Copy link
Contributor

@akarasavov akarasavov commented Jun 25, 2024 •
edited
Loading

@NataliaIvakina NataliaIvakina self-assigned this Jun 25, 2024
NataliaIvakina
NataliaIvakina reviewed Jun 26, 2024
View reviewed changes
yirensum
yirensum reviewed Jun 26, 2024
View reviewed changes
modules/ROOT/pages/reference/procedures.adoc Outdated
[cols="<15s,<85"]
|===
| Description
a| This procedure allows you to select which discovery service should be started.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding a note like "Note that transitions must be done in order, which means it is not possible to switch to V2_OVER_V1 when current server is in V1_ONLY, the server must first go be switched to V1_OVER_V2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to do this because other procedures don't describe their contract in this document(correct me if I'm wrong). Also If a customer tries to do illegal transitions, this procedure will crash and print an informative message about the right transition. You can find what message will be printed here com.neo4j.causalclustering.discovery.parallel.ParallelTopologyService#switchMode.

yirensum
yirensum reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@yirensum yirensum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than one suggestion

akarasavov and others added 4 commits June 27, 2024 10:01
@akarasavov @NataliaIvakina
Update modules/ROOT/pages/reference/procedures.adoc
5b68809 
Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com>
@akarasavov @NataliaIvakina
Update modules/ROOT/pages/reference/procedures.adoc
22050df 
Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com>
@akarasavov @NataliaIvakina
Update modules/ROOT/pages/reference/procedures.adoc
c8bc9ba 
Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com>
@akarasavov @NataliaIvakina
Update modules/ROOT/pages/reference/procedures.adoc
286d01a 
Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com>
renetapopova
renetapopova requested changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The descriptions look very good but should be the same in the codebase. Otherwise, our test will fail.

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Jul 1, 2024 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@akarasavov akarasavov requested a review from renetapopova July 1, 2024 11:16
renetapopova
renetapopova approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@renetapopova renetapopova merged commit 9026fd9 into dev Jul 1, 2024
@renetapopova renetapopova deleted the add_lighthouse_procedures branch July 1, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NataliaIvakina NataliaIvakina NataliaIvakina left review comments

@yirensum yirensum yirensum left review comments

@renetapopova renetapopova renetapopova approved these changes

Assignees

@NataliaIvakina NataliaIvakina

@yirensum yirensum

Labels

5.22 clustering

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@akarasavov @neo-technology-commit-status-publisher @renetapopova @NataliaIvakina @yirensum