Skip to content

Explain the importance of checkpointing for backups #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 16, 2024
Merged

Explain the importance of checkpointing for backups #1793

merged 11 commits into from
Sep 16, 2024

Conversation

@NataliaIvakina
Copy link
Collaborator

No description provided.

@MishaDemianenko MishaDemianenko self-assigned this Aug 28, 2024
tselmegbaasan
tselmegbaasan requested changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@tselmegbaasan tselmegbaasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Just a few suggestions on clarifications.

MishaDemianenko
MishaDemianenko requested changes Aug 28, 2024
View reviewed changes
NataliaIvakina
NataliaIvakina commented Aug 29, 2024
View reviewed changes
tselmegbaasan
tselmegbaasan approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@tselmegbaasan tselmegbaasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

renetapopova
renetapopova requested changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked into this again, and I see that the backup can also time out for other reasons, such as server unavailability or general unresponsiveness, local or network resources, etc. Perhaps we could include those as well, and instead of talking about checkpointing only, we could replace this section with a section specific to the backup timeout configurations and include the checkpoint problems as part of it.

renetapopova
renetapopova reviewed Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Natalia. I added some comments.

@NataliaIvakina @renetapopova
Apply suggestions from code review
46c493c 
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
NataliaIvakina
NataliaIvakina commented Sep 13, 2024
View reviewed changes
NataliaIvakina
NataliaIvakina commented Sep 13, 2024
View reviewed changes
renetapopova
renetapopova approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to go now. Thanks for your patience 😄

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Sep 16, 2024 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@NataliaIvakina NataliaIvakina merged commit 112f7f1 into neo4j:dev Sep 16, 2024
8 checks passed
@NataliaIvakina NataliaIvakina deleted the dev-backup-checkpoint branch September 16, 2024 08:24
NataliaIvakina added a commit to NataliaIvakina/docs-operations that referenced this pull request Sep 16, 2024
@NataliaIvakina @renetapopova
Explain the importance of checkpointing for backups (neo4j#1793)
fc2cdd4 
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
NataliaIvakina added a commit to NataliaIvakina/docs-operations that referenced this pull request Sep 16, 2024
@NataliaIvakina @renetapopova
Explain the importance of checkpointing for backups (neo4j#1793)
624d2d8 
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
NataliaIvakina added a commit that referenced this pull request Sep 16, 2024
@NataliaIvakina @renetapopova
Explain the importance of checkpointing for backups (#1793) (#1810)
24b452f 
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
NataliaIvakina added a commit that referenced this pull request Sep 16, 2024
@NataliaIvakina @renetapopova
Explain the importance of checkpointing for backups (#1793) (#1811)
16d1cd3 
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renetapopova renetapopova renetapopova approved these changes

@tselmegbaasan tselmegbaasan tselmegbaasan approved these changes

@MishaDemianenko MishaDemianenko Awaiting requested review from MishaDemianenko

Assignees

@MishaDemianenko MishaDemianenko

Labels

cherry-pick-this-to-4.4 cherry-pick-this-to-5.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NataliaIvakina @neo-technology-commit-status-publisher @renetapopova @MishaDemianenko @tselmegbaasan