-
Notifications
You must be signed in to change notification settings - Fork 83
Added detail on backup compression flag #1808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this clarification, @tonbut! Just minor editorial suggestions. We need to update the description in the neo4j repository as well because the descriptions are tested against it.
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
|
Thanks @renetapopova for polishing the text |
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
|
@renetapopova is this blocked? do i need to approve your changes, or request re-review. I'm happy with changes if you are |
@tonbut We just need to update the description in the neo4j-repo as well before we can merge this one. Could you be able to do that? This will make @neo-technology-commit-status-publisher neo4j-admin tools (PRs) (Testing) — to go green. |
|
PR on mono-repo to update neo4j-admin help text is merged now, let's hope it passes soon here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tonbut! I think it's okay to merge it now. We'll publish it when 5.24 is out, so you don't need to cherry-pick it.
Ideally, it should be published in 5.25, when the description will also be available in the code. But I think in this case, it's better to be out sooner than later.
This support case shows how a customer is misled by absolute description of backup being faster when compression is disabled. https://trello.com/c/xsCLZrwy/7747-s3dbs-risk-management5181-backup-is-taking-more-time-with-compressfalse --------- Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
This support case shows how a customer is misled by absolute description of backup being faster when compression is disabled.
https://trello.com/c/xsCLZrwy/7747-s3dbs-risk-management5181-backup-is-taking-more-time-with-compressfalse