Skip to content

Conversation

@tonbut
Copy link
Contributor

@tonbut tonbut commented Sep 10, 2024

This support case shows how a customer is misled by absolute description of backup being faster when compression is disabled.

https://trello.com/c/xsCLZrwy/7747-s3dbs-risk-management5181-backup-is-taking-more-time-with-compressfalse

Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this clarification, @tonbut! Just minor editorial suggestions. We need to update the description in the neo4j repository as well because the descriptions are tested against it.

Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
@tonbut
Copy link
Contributor Author

tonbut commented Sep 12, 2024

Thanks @renetapopova for polishing the text

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Sep 12, 2024

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@tonbut
Copy link
Contributor Author

tonbut commented Sep 13, 2024

@renetapopova is this blocked? do i need to approve your changes, or request re-review. I'm happy with changes if you are

@renetapopova
Copy link
Collaborator

renetapopova commented Sep 13, 2024

@renetapopova is this blocked? do i need to approve your changes, or request re-review. I'm happy with changes if you are

@tonbut We just need to update the description in the neo4j-repo as well before we can merge this one. Could you be able to do that? This will make @neo-technology-commit-status-publisher neo4j-admin tools (PRs) (Testing) — to go green.

@renetapopova renetapopova self-requested a review September 13, 2024 14:20
@tonbut
Copy link
Contributor Author

tonbut commented Sep 18, 2024

PR on mono-repo to update neo4j-admin help text is merged now, let's hope it passes soon here.
https://github.com/neo-technology/neo4j/pull/27199

Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tonbut! I think it's okay to merge it now. We'll publish it when 5.24 is out, so you don't need to cherry-pick it.

Ideally, it should be published in 5.25, when the description will also be available in the code. But I think in this case, it's better to be out sooner than later.

@renetapopova renetapopova merged commit a2bffb1 into neo4j:dev Sep 20, 2024
renetapopova added a commit to renetapopova/docs-operations that referenced this pull request Sep 26, 2024
This support case shows how a customer is misled by absolute description
of backup being faster when compression is disabled.


https://trello.com/c/xsCLZrwy/7747-s3dbs-risk-management5181-backup-is-taking-more-time-with-compressfalse

---------

Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants