Skip to content

Conversation

@renetapopova
Copy link
Collaborator

@renetapopova renetapopova commented Feb 13, 2025

@HannesSandberg, The models/hospital folder is for internal use only. So, there is no need to review the files in it.

@renetapopova renetapopova changed the title Add the models/hospital folder from manual-modeling Updates the hospital example to include steps on how to create and load the healthcare database Feb 17, 2025
@renetapopova
Copy link
Collaborator Author

Copy link
Collaborator

@NataliaIvakina NataliaIvakina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I don't see anything suspicious or wrong.
This might be a stupid question, but you have to run all cmds related to granting/denying roles against the system db, right? Does this mean you need to switch to the system db? See line 1010. It's the first time when we mentioned the system db. Do we need to add here a line on how to switch to the system db or it's clear enough for users?

@renetapopova
Copy link
Collaborator Author

Looks great! I don't see anything suspicious or wrong. This might be a stupid question, but you have to run all cmds related to granting/denying roles against the system db, right? Does this mean you need to switch to the system db? See line 1010. It's the first time when we mentioned the system db. Do we need to add here a line on how to switch to the system db or it's clear enough for users?

Yes, all of them are run against the system db. I think there were a few more mentions, but yes, we could add this to each admin command.

Copy link
Contributor

@HannesSandberg HannesSandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! I have a few minor comments

| "GRANT ACCESS ON DATABASE `healthcare` TO $role" |
| "GRANT EXECUTE PROCEDURE * ON DBMS TO $role" |
| "GRANT ACCESS ON DATABASE `neo4j` TO $role" |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should drop the database neo4j, since it is not relevant to this tutorial?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe because the default home database is neo4j, all these privileges are automatically granted to users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, if we drop the neo4j database you can make the output a little bit clearer without having the neo4j db.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update it later.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @HannesSandberg, instead of dropping neo4j, I decided to change the default database to healthcare. This is just one step after creating the database. Otherwise, I had to add a step for each user to log into healthcare; otherwise, Neo4j throws an authentication error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution 👍

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Feb 20, 2025

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova merged commit 1023dd4 into neo4j:dev Feb 20, 2025
8 checks passed
@renetapopova renetapopova deleted the dev-hospital-example branch February 20, 2025 11:32
renetapopova added a commit to renetapopova/docs-operations that referenced this pull request Feb 20, 2025
…ad the healthcare database (neo4j#2119)

@HannesSandberg, The `models/hospital` folder is for internal use only.
So, there is no need to review the files in it.
renetapopova added a commit to renetapopova/docs-operations that referenced this pull request Feb 20, 2025
…ad the healthcare database (neo4j#2119)

@HannesSandberg, The `models/hospital` folder is for internal use only.
So, there is no need to review the files in it.
renetapopova added a commit that referenced this pull request Feb 20, 2025
renetapopova added a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants