-
Notifications
You must be signed in to change notification settings - Fork 83
Updates the hospital example to include steps on how to create and load the healthcare database #2119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…te the examples accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I don't see anything suspicious or wrong.
This might be a stupid question, but you have to run all cmds related to granting/denying roles against the system db, right? Does this mean you need to switch to the system db? See line 1010. It's the first time when we mentioned the system db. Do we need to add here a line on how to switch to the system db or it's clear enough for users?
Yes, all of them are run against the system db. I think there were a few more mentions, but yes, we could add this to each admin command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! I have a few minor comments
| | "GRANT ACCESS ON DATABASE `healthcare` TO $role" | | ||
| | "GRANT EXECUTE PROCEDURE * ON DBMS TO $role" | | ||
| | "GRANT ACCESS ON DATABASE `neo4j` TO $role" | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should drop the database neo4j, since it is not relevant to this tutorial?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe because the default home database is neo4j, all these privileges are automatically granted to users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, if we drop the neo4j database you can make the output a little bit clearer without having the neo4j db.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @HannesSandberg, instead of dropping neo4j, I decided to change the default database to healthcare. This is just one step after creating the database. Otherwise, I had to add a step for each user to log into healthcare; otherwise, Neo4j throws an authentication error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution 👍
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
…ad the healthcare database (neo4j#2119) @HannesSandberg, The `models/hospital` folder is for internal use only. So, there is no need to review the files in it.
…ad the healthcare database (neo4j#2119) @HannesSandberg, The `models/hospital` folder is for internal use only. So, there is no need to review the files in it.
@HannesSandberg, The
models/hospitalfolder is for internal use only. So, there is no need to review the files in it.