Skip to content

Conversation

@renetapopova
Copy link
Collaborator

No description provided.

@renetapopova renetapopova changed the title Add connection exception errors Add connection exception errors - part 1 Oct 8, 2024
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. Most comments are just on smaller things but we might want to discuss the parameter formatting comment a bit

@renetapopova renetapopova force-pushed the standard-defined-connection-exceptions branch from c8cc746 to 87645d8 Compare October 11, 2024 17:45
@renetapopova renetapopova changed the title Add connection exception errors - part 1 Add connection exception errors Oct 11, 2024
@renetapopova renetapopova requested a review from Lojjs October 14, 2024 12:58
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found 2 minor misstakes, otherwise it looks good

Comment on lines +96 to +114
=== Standard-defined GQLSTATUS notification codes

The GQL standard defines a set of GQLSTATUS codes that are used to represent successful completion, warnings, and informational messages.
The following table lists the standard-defined GQLSTATUS codes and their meanings:

.Standard-defined GQLSTATUS notification codes
[options="header", cols="<1s,<4"]
|===
|GQLSTATUS code | StatusDescription
| 00000 | note: successful completion
| 00001 | note: successful completion - omitted result
| 01000 | warn: warning
| 01004 | warn: string data, right truncation
| 01G03 | warn: graph does not exist
| 01G04 | warn: graph type does not exist
| 01G11 | warn: null value eliminated in set function
| 02000 | note: no data
| 03000 | info: informational
|===
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember what we said about this, should we keep it or not? I'm open for either, we can always revisit later.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense for notifications, as the list is short, and it looks good in the structure, but I also don't have a strong opinion. Should I create a card to change the format of the notification parameters?

renetapopova and others added 2 commits October 15, 2024 13:06
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Oct 15, 2024

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova requested a review from Lojjs October 15, 2024 12:11
@renetapopova renetapopova merged commit de4096c into neo4j:gqlstatus-errors Oct 15, 2024
5 checks passed
@renetapopova renetapopova deleted the standard-defined-connection-exceptions branch October 15, 2024 12:19
renetapopova added a commit that referenced this pull request Oct 31, 2024
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
renetapopova added a commit to renetapopova/docs-status-codes that referenced this pull request Oct 31, 2024
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants