- 
                Notifications
    You must be signed in to change notification settings 
- Fork 35
Add connection exception errors #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connection exception errors #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. Most comments are just on smaller things but we might want to discuss the parameter formatting comment a bit
c8cc746    to
    87645d8      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just found 2 minor misstakes, otherwise it looks good
| === Standard-defined GQLSTATUS notification codes | ||
|  | ||
| The GQL standard defines a set of GQLSTATUS codes that are used to represent successful completion, warnings, and informational messages. | ||
| The following table lists the standard-defined GQLSTATUS codes and their meanings: | ||
|  | ||
| .Standard-defined GQLSTATUS notification codes | ||
| [options="header", cols="<1s,<4"] | ||
| |=== | ||
| |GQLSTATUS code | StatusDescription | ||
| | 00000 | note: successful completion | ||
| | 00001 | note: successful completion - omitted result | ||
| | 01000 | warn: warning | ||
| | 01004 | warn: string data, right truncation | ||
| | 01G03 | warn: graph does not exist | ||
| | 01G04 | warn: graph type does not exist | ||
| | 01G11 | warn: null value eliminated in set function | ||
| | 02000 | note: no data | ||
| | 03000 | info: informational | ||
| |=== | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remember what we said about this, should we keep it or not? I'm open for either, we can always revisit later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense for notifications, as the list is short, and it looks good in the structure, but I also don't have a strong opinion. Should I create a card to change the format of the notification parameters?
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
| Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. | 
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
No description provided.