Skip to content

Conversation

@hedengran
Copy link

@hedengran hedengran commented Feb 2, 2023

  • Add missing section for already existing notification code RepeatedRelationshipReference.
  • Add an example, which cover the only scenario for which the notification code is issued.

@hedengran hedengran added dev The default branch. 5.x LTS version labels Feb 2, 2023
@hedengran hedengran force-pushed the repeated-relationship-reference branch from 73e7e1d to bd3f7a6 Compare February 2, 2023 14:04
Copy link
Contributor

@LinneaAndersson LinneaAndersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor comments :)

@hedengran hedengran force-pushed the repeated-relationship-reference branch from c72ee3f to bdf090d Compare February 9, 2023 10:27
@hedengran hedengran force-pushed the repeated-relationship-reference branch from bdf090d to c9fc3c1 Compare February 13, 2023 10:33
@hedengran hedengran changed the title Add RepeatedRelationshipReference and provide examples Add RepeatedRelationshipReference and provide example Feb 13, 2023
Copy link
Contributor

@LinneaAndersson LinneaAndersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor comment

Co-authored-by: LinneaAndersson <linneamaria10@gmail.com>
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hedengran! I added some suggestions.

Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@hedengran hedengran merged commit 0b16f7e into neo4j:dev Feb 15, 2023
@hedengran hedengran deleted the repeated-relationship-reference branch February 15, 2023 10:13
hedengran pushed a commit that referenced this pull request Feb 16, 2023
…hip variable more than once" (#40)

- Removing deprecation examples for "repeated variable length
relationship references" since they are being "undeprecated".
- Adding example `Binding a variable-length relationship variable more
than once` to demonstrate a new notification.

Build on top of #35.
recrwplay pushed a commit that referenced this pull request Feb 16, 2023
- Add missing section for already existing notification code
`RepeatedRelationshipReference`.
- Add an example, which cover the only scenario for which the
notification code is issued.

---------

Co-authored-by: LinneaAndersson <linneamaria10@gmail.com>
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
renetapopova pushed a commit to renetapopova/docs-status-codes that referenced this pull request May 31, 2023
…hip variable more than once" (neo4j#40)

- Removing deprecation examples for "repeated variable length
relationship references" since they are being "undeprecated".
- Adding example `Binding a variable-length relationship variable more
than once` to demonstrate a new notification.

Build on top of neo4j#35.
renetapopova added a commit that referenced this pull request May 31, 2023
#64)

Cherry-picked from #40 

- Removing deprecation examples for "repeated variable length
relationship references" since they are being "undeprecated".
- Adding example `Binding a variable-length relationship variable more
than once` to demonstrate a new notification.

Build on top of #35.

Co-authored-by: Gustav Hedengran <gustav@hedengran.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants