-
Notifications
You must be signed in to change notification settings - Fork 35
Add RepeatedRelationshipReference and provide example #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RepeatedRelationshipReference and provide example #35
Conversation
73e7e1d to
bd3f7a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor comments :)
c72ee3f to
bdf090d
Compare
bdf090d to
c9fc3c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a minor comment
Co-authored-by: LinneaAndersson <linneamaria10@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @hedengran! I added some suggestions.
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
- Add missing section for already existing notification code `RepeatedRelationshipReference`. - Add an example, which cover the only scenario for which the notification code is issued. --------- Co-authored-by: LinneaAndersson <linneamaria10@gmail.com> Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
…hip variable more than once" (neo4j#40) - Removing deprecation examples for "repeated variable length relationship references" since they are being "undeprecated". - Adding example `Binding a variable-length relationship variable more than once` to demonstrate a new notification. Build on top of neo4j#35.
#64) Cherry-picked from #40 - Removing deprecation examples for "repeated variable length relationship references" since they are being "undeprecated". - Adding example `Binding a variable-length relationship variable more than once` to demonstrate a new notification. Build on top of #35. Co-authored-by: Gustav Hedengran <gustav@hedengran.net>
RepeatedRelationshipReference.