- 
                Notifications
    You must be signed in to change notification settings 
- Fork 35
added oidc credential forwarding not enabled notification #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added oidc credential forwarding not enabled notification #391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a suggestion. Is dbms.security.allow_oidc_credential_forwarding_enabled a new configuration setting? If yes, we need to document it in the Operations manual.
d0225de    to
    35325d6      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @evelinadanielsson. I added a suggestion.
|  | ||
| Suggestions for improvement:: | ||
| Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting. | ||
| Until enabled, all access attempts to the new remote database alias will fail. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Until enabled, all access attempts to the new remote database alias will fail. | 
| ---- | ||
|  | ||
| Suggestions for improvement:: | ||
| Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting. | |
| Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting to gain access to the remote database alias. | 
| Use the setting 'dbms.security.allow_oidc_credential_forwarding_enabled' to enable OIDC credential forwarding. | ||
|  | ||
| Suggestions for improvement:: | ||
| Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting. | |
| Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting to gain access to the remote database alias. | 
|  | ||
| Suggestions for improvement:: | ||
| Enable OIDC credential forwarding through the `dbms.security.allow_oidc_credential_forwarding_enabled` setting. | ||
| The remote database alias has been created successfully, however all attempts to access it will fail, unless the setting is enabled. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The remote database alias has been created successfully, however all attempts to access it will fail, unless the setting is enabled. | 
8ec1964    to
    6496f96      
    Compare
  
    6496f96    to
    f4cfef5      
    Compare
  
    | Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @evelinadanielsson. Looks good, I have added just one question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both.
Adding notification and status code 01N74 introduced in this PR