Skip to content

update class and subclass #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 19, 2023
Merged

update class and subclass #83

merged 8 commits into from
Oct 19, 2023

Conversation

@renetapopova
Copy link
Collaborator

No description provided.

@renetapopova renetapopova requested a review from Lojjs October 12, 2023 13:59
Lojjs
Lojjs reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the type/subtype thing looks correct, but had two comments on the related changes.

@renetapopova renetapopova requested a review from Lojjs October 13, 2023 11:52
Lojjs
Lojjs reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to make it even more aligned and clear how the different terms are related to each other

renetapopova and others added 5 commits October 19, 2023 12:59
@renetapopova @Lojjs
Update modules/ROOT/pages/notifications/index.adoc
ee3336e 
Co-authored-by: Louise Söderström <louise.soderstrom@neo4j.com>
@renetapopova @Lojjs
Update README.adoc
9e80b30 
Co-authored-by: Louise Söderström <louise.soderstrom@neo4j.com>
@renetapopova @Lojjs
Update modules/ROOT/pages/errors/index.adoc
b036142 
Co-authored-by: Louise Söderström <louise.soderstrom@neo4j.com>
@renetapopova @Lojjs
Update modules/ROOT/pages/errors/index.adoc
a58b477 
Co-authored-by: Louise Söderström <louise.soderstrom@neo4j.com>
@renetapopova
minor editorial updates
bae3be6
@renetapopova renetapopova merged commit 83d0ba6 into neo4j:dev Oct 19, 2023
@renetapopova renetapopova deleted the dev-rename-class branch October 19, 2023 12:15
renetapopova added a commit to renetapopova/docs-status-codes that referenced this pull request Oct 19, 2023
@renetapopova @Lojjs
update class and subclass (neo4j#83)
bab17b8 
Co-authored-by: Louise Söderström <louise.soderstrom@neo4j.com>
renetapopova added a commit that referenced this pull request Oct 19, 2023
@renetapopova @Lojjs
update class and subclass (#83) (#87)
fd8b8ba 
Co-authored-by: Louise Söderström <louise.soderstrom@neo4j.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lojjs Lojjs Lojjs left review comments

Assignees

No one assigned

Labels

cherry-pick this to 5.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@renetapopova @Lojjs