JobId-based remote writeback #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DarthMax
commented
Mar 27, 2024
DarthMax
commented
- Introduce GdsArrowClient
- Use GdsArrowClient in ArrowGraphConstruction and ArrowQueryRunner
- Adapt client to push based remote projection
- Fix most style and typing issues
✅ Deploy Preview for neo4j-graph-data-science-client canceled.
|
Contributor
Author
DarthMax
force-pushed
the
push_based_remote_projection
branch
from
ac4c576 to
e91cfae
Compare
Mats-SX
force-pushed
the
push_based_remote_projection
branch
from
e91cfae to
4cb9192
Compare
DarthMax
force-pushed
the
push_based_remote_projection
branch
from
c6cfac9 to
6e1f683
Compare
DarthMax
force-pushed
the
push_based_remote_projection
branch
3 times, most recently
from
b441725 to
36cdf82
Compare
FlorentinD
reviewed
Apr 23, 2024
Contributor
FlorentinD
left a comment
FlorentinD
left a comment
There was a problem hiding this comment.
Nice refactoring of the flight client logic.
Mostly minor comments around the write-back logic.
Mats-SX
changed the title
Mats-SX
changed the title
Mats-SX
force-pushed
the
push_based_remote_projection
branch
2 times, most recently
from
6d35501 to
75a45e6
Compare
Mats-SX
force-pushed
the
push_based_remote_projection
branch
from
1d30cdc to
f90f9e6
Compare
Mats-SX
changed the title
Contributor
Mats-SX
force-pushed
the
push_based_remote_projection
branch
from
d97d4de to
6c6d9a9
Compare
Contributor
|
|
soerenreichardt
force-pushed
the
push_based_remote_projection
branch
2 times, most recently
from
4a39dad to
8bee5b0
Compare
signatures
this allows for example:
gds.degree.write(G, arrowConfiguration={batchSize: 1})
gds.graph.nodeProperties.write(G, "prop", [], arrowConfiguration={batchSize: 1})
Co-authored-by: Max Kießling <max.kiessling@neotechnology.com>
Co-authored-by: Sören Reichardt <soren.reichardt@neo4j.com>
In remote write unit tests
Co-Authored-By: Florentin Dörre <florentin.dorre@neo4j.com>
Mats-SX
force-pushed
the
push_based_remote_projection
branch
from
ec470cb to
fe1f71d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.