Skip to content

Conversation

@orazve
Copy link
Contributor

@orazve orazve commented Jun 11, 2024

Thank you for your contribution to the Graph Data Science Client project.

Before submitting this PR, please read Contributing to the Neo4j Ecosystem.

Make sure:

  • You signed the Neo4j CLA (Contributor License Agreement) so that we are allowed to ship your code in our library
  • Your contribution is covered by tests

@netlify
Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for neo4j-graph-data-science-client ready!

Name Link
🔨 Latest commit 26d81c3
🔍 Latest deploy log https://app.netlify.com/sites/neo4j-graph-data-science-client/deploys/667aa28a9a43380009a35bd4
😎 Deploy Preview https://deploy-preview-660--neo4j-graph-data-science-client.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@adamnsch adamnsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work! Just added some comments :)

@orazve orazve marked this pull request as ready for review June 20, 2024 13:22
@orazve orazve requested a review from adamnsch June 20, 2024 13:22
Copy link
Contributor

@adamnsch adamnsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, great work! Have mostly minor comments :)

orazve and others added 8 commits June 24, 2024 11:41
…gs.adoc

Co-authored-by: Adam Schill Collberg <53664324+adamnsch@users.noreply.github.com>
…gs.adoc

Co-authored-by: Adam Schill Collberg <53664324+adamnsch@users.noreply.github.com>
…gs.adoc

Co-authored-by: Adam Schill Collberg <53664324+adamnsch@users.noreply.github.com>
Co-authored-by: Adam Schill Collberg <adam.schill.collberg@protonmail.com>

Co-authored-by: Adam Schill Collberg <53664324+adamnsch@users.noreply.github.com>
@orazve orazve merged commit c7491b4 into neo4j:main Jun 25, 2024
@orazve orazve deleted the kge-doc branch June 25, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants