Dedicated session memory checks #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DarthMax
commented
Jun 13, 2024
DarthMax
commented
- Use actual types for instance memory specifications
- Check if a dedicated session exists with a different memory configuration
✅ Deploy Preview for neo4j-graph-data-science-client ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
FlorentinD
requested changes
Jun 13, 2024
Contributor
FlorentinD
left a comment
FlorentinD
left a comment
There was a problem hiding this comment.
The check itself looks good.
I am have some comments about the refactoring / api-change.
FlorentinD
approved these changes
Jun 14, 2024
Contributor
FlorentinD
left a comment
FlorentinD
left a comment
There was a problem hiding this comment.
LGTM. Only some small suggestions
FlorentinD
force-pushed
the
dedicated-session-check-memory
branch
from
1f33c05 to
bc4ef15
Compare
* We will keep the enum to make the selection easier for users
FlorentinD
force-pushed
the
dedicated-session-check-memory
branch
from
bc4ef15 to
1e0e3c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.