Run session notebook against fresh db #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-graph-data-science-client canceled.
|
Mats-SX
approved these changes
Jul 11, 2024
Contributor
Mats-SX
left a comment
Mats-SX
left a comment
There was a problem hiding this comment.
I like the changes. I suggest we name the files a bit more explicitly to make it clearer how they are different.
| instance_name = f"ci-build-{sys.argv[2]}" if len(sys.argv) > 1 else "ci-instance-" + str(rd.randint(0, MAX_INT)) | ||
|
|
||
| create_result = create_instance(instance_name, access_token) | ||
| create_result = aura_api.create_ds_instance(instance_name) |
Contributor
There was a problem hiding this comment.
So this file runs tests and notebooks using just an AuraDS instance?
I suggest renaming the file run_targeting_aurads
Contributor
There was a problem hiding this comment.
I realise this will need another TC change
| username = (create_result["username"],) | ||
| password = (create_result["password"],) | ||
|
|
||
| cmd = f"AURA_DB_ADDRESS={uri} AURA_DB_USER={username} AURA_DB_PW={password} tox -e jupyter-notebook-session-ci" |
Contributor
There was a problem hiding this comment.
Meanwhile, this test runs with an AuraDB instance and dedicated or AuraDS-based sessions.
I suggest renaming it run_sessions_targeting_auradb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Graph Data Science Client project.
Before submitting this PR, please read Contributing to the Neo4j Ecosystem.
Make sure: