Skip to content

Conversation

@dhrudevalia
Copy link
Contributor

@dhrudevalia dhrudevalia commented Jan 2, 2025

Issue

When calling the GDS read functions we are not using the lazy serialisation client.
This is required for the BigQueryConnector which uses this library instead of neo4j-arrow.
Follow-up from: #804

Fix

Use self._client() instead of the _flight_client directly so that it can be lazy initialised if needed.

@netlify
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for neo4j-graph-data-science-client canceled.

Name Link
🔨 Latest commit 613f44b
🔍 Latest deploy log https://app.netlify.com/sites/neo4j-graph-data-science-client/deploys/67769f04e72e3e00089745c3

@FlorentinD FlorentinD self-assigned this Jan 2, 2025
Copy link
Contributor

@FlorentinD FlorentinD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking on other usage, I think we also need to fix some other places:

client = self._client()
try:
get = self._flight_client.do_get(ticket)
get = client.do_get(ticket)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense.

@dhrudevalia
Copy link
Contributor Author

Checking on other usage, I think we also need to fix some other places:

Yep good shout. I've updated the token fetching + close method as suggested.

@dhrudevalia dhrudevalia requested a review from FlorentinD January 2, 2025 14:13
@FlorentinD FlorentinD enabled auto-merge (squash) January 2, 2025 14:18
@FlorentinD FlorentinD merged commit 359156e into neo4j:main Jan 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants