Only scroll to top of stream when frame is added and toggle is on #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfannuri
reviewed
May 5, 2017
| export const getMaxNeighbours = (state) => state[NAME].maxNeighbours || initialState.maxNeighbours | ||
| export const getMaxRows = (state) => state[NAME].maxRows || initialState.maxRows | ||
| export const getInitialNodeDisplay = (state) => state[NAME].initialNodeDisplay || initialState.initialNodeDisplay | ||
| export const getScrollToTop = (state) => state[NAME].scrollToTop || initialState.scrollToTop |
Contributor
There was a problem hiding this comment.
@pe4cey I believe default value should be true to preserve previous behaviour. Because the setting is new and so gets false by default
pe4cey
force-pushed
the
3.0-stop-to-top-on-frame-removal
branch
from
8e01aa4 to
44f885b
Compare
pe4cey
force-pushed
the
3.0-stop-to-top-on-frame-removal
branch
from
44f885b to
c969b94
Compare
irfannuri
force-pushed
the
3.0-stop-to-top-on-frame-removal
branch
from
7d2c170 to
c4d51a8
Compare
pe4cey
force-pushed
the
3.0-stop-to-top-on-frame-removal
branch
from
c4d51a8 to
dc4e327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scroll to top will only kick in once a frame is added (this handles rerun/frame removal issues we've had)
Added toggle to the sidebar
