Skip to content

Improve the structure of the deprecations page #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 19, 2022
Merged

Improve the structure of the deprecations page #1374

merged 5 commits into from
Jan 19, 2022

Conversation

@renetapopova
Copy link
Contributor

@renetapopova renetapopova commented Jan 18, 2022 •
edited
Loading

Cherry-picked from #1348 and #1353

@Hunterness Hunterness self-assigned this Jan 18, 2022
Hunterness
Hunterness reviewed Jan 18, 2022
View reviewed changes
Copy link
Contributor

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good cherry-pick but it doesn't seem to update the 5.0 one to follow format? Shouldn't there at least be a Removed features header like for 4.0?

@renetapopova
Copy link
Contributor Author

renetapopova commented Jan 18, 2022

This looks like a good cherry-pick but it doesn't seem to update the 5.0 one to follow format? Shouldn't there at least be a Removed features header like for 4.0?

This one just cherry-picks the updates up to 4.4. Then, we should create another PR with the 5.0 changes, I guess when #1328 and #1340 are merged.

@Hunterness
Copy link
Contributor

Hunterness commented Jan 18, 2022

This one just cherry-picks the updates up to 4.4. Then, we should create another PR with the 5.0 changes, I guess when #1328 and #1340 are merged.

Since #1340 is merged and #1328 is currently blocked on product pr and anyway needs rebasing and updating I think you could update the 5.0 changes here and then I'll fix #1328 based on all changes instead of it needing to be updated twice?

@renetapopova
Copy link
Contributor Author

renetapopova commented Jan 18, 2022

This one just cherry-picks the updates up to 4.4. Then, we should create another PR with the 5.0 changes, I guess when #1328 and #1340 are merged.

Since #1340 is merged and #1328 is currently blocked on product pr and anyway needs rebasing and updating I think you could update the 5.0 changes here and then I'll fix #1328 based on all changes instead of it needing to be updated twice?

OK, I'll do that.

@Hunterness Hunterness mentioned this pull request Jan 19, 2022
Merged
@renetapopova renetapopova force-pushed the 5.0-group-deprecations branch from cca1711 to ec562da Compare January 19, 2022 10:49
@renetapopova renetapopova merged commit 17408c9 into neo4j:dev Jan 19, 2022
@renetapopova renetapopova deleted the 5.0-group-deprecations branch January 19, 2022 11:26
@martin-neotech martin-neotech added the static This is a temporary label, used to check if this PR has been moved into the static repository. label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hunterness Hunterness Hunterness approved these changes

Assignees

@Hunterness Hunterness

Labels

5.0 cherry-picked static This is a temporary label, used to check if this PR has been moved into the static repository.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@renetapopova @Hunterness @martin-neotech