Skip to content

Remove Mustache #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Remove Mustache #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f04946
Remove Mustache
bigmontz Apr 21, 2022
64e8408
Remove the dependency
bigmontz Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions packages/neo4j-driver/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/neo4j-driver/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@
"lodash": "^4.17.21",
"lolex": "^6.0.0",
"minimist": "^1.2.6",
"mustache": "^4.2.0",
"nyc": "^15.1.0",
"run-sequence": "^2.2.1",
"semver": "^7.3.5",
Expand Down
15 changes: 0 additions & 15 deletions packages/neo4j-driver/test/internal/bolt-stub.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,6 @@ class UnsupportedBoltStub {
start (script, port) {
throw new Error('BoltStub: unable to start, unavailable on this platform')
}

startWithTemplate (scriptTemplate, parameters, port) {
throw new Error(
'BoltStub: unable to start with template, unavailable on this platform'
)
}
}

const verbose = (process.env.NEOLOGLEVEL || 'error').toLowerCase() === 'debug' // for debugging purposes
Expand Down Expand Up @@ -115,14 +109,6 @@ class SupportedBoltStub extends UnsupportedBoltStub {
tryConnect()
})
}

startWithTemplate (scriptTemplate, parameters, port) {
const template = this._fs.readFileSync(scriptTemplate, 'utf-8')
const scriptContents = this._mustache.render(template, parameters)
const script = this._tmp.fileSync().name
this._fs.writeFileSync(script, scriptContents, 'utf-8')
return this.start(script, port)
}
}

class StubServer {
Expand Down Expand Up @@ -182,6 +168,5 @@ const stub = supported ? supportedStub : new UnsupportedBoltStub()
export default {
supported: supported,
start: stub.start.bind(stub),
startWithTemplate: stub.startWithTemplate.bind(stub),
newDriver: newDriver
}