[5.28] Harden Structure against memory leak
#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extensions implementation of packstream `Structure` could leak memory when being part of a reference cycle. In reality this doesn't matter because the driver never constructs cyclic `Structure`s. Every packstream value is a tree in terms of references (both directions: packing and unpacking). This change is meant to harden the extensions against introducing effective memory leaks in the driver should the driver's usage of `Structure` change in the future. See also https://pyo3.rs/v0.22.0/class/protocols#garbage-collector-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extensions implementation of packstream
Structurecould leak memory when being part of a reference cycle. In reality this doesn't matter because the driver never constructs cyclicStructures. Every packstream value is a tree in terms of references (both directions: packing and unpacking).This change is meant to harden the extensions against introducing effective memory leaks in the driver should the driver's usage of
Structurechange in the future.See also https://pyo3.rs/v0.22.0/class/protocols#garbage-collector-integration
Backport of:
Structureagainst memory leak #50