[4.4] Fix ITs in TeamCity #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For god know what reason (couldn't reproduce locally, tried every trick in the book), boltkit shutting down Neo4j after the ITs would timeout consistently in TeamCity. Since the service is (at least currently) started and stopped for the whole test session, not per test, there's little risk in just killing it instead of gracefully shutting it down.
robsdedude
force-pushed
the
fix/work-around-tc-failure
branch
from
8a43ebd to
04735df
Compare
AndyHeap-NeoTech
approved these changes
Apr 10, 2024
Contributor
AndyHeap-NeoTech
left a comment
AndyHeap-NeoTech
left a comment
There was a problem hiding this comment.
A thing of beauty that we shan't mention to anyone else. Approved.
RichardIrons-neo4j
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For god know what reason (couldn't reproduce locally, tried every trick in the book), boltkit shutting down Neo4j after the ITs would timeout consistently in TeamCity. Since the service is (at least currently) started and stopped for the whole test session, not per test, there's little risk in just killing it instead of gracefully shutting it down.