Skip to content

Try all resolved addresses for direct connection #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2017
Merged

Try all resolved addresses for direct connection #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fc56d8
Try all resolved addresses for direct connection
technige Mar 30, 2017
5037255
Removed extraneous argument
technige Mar 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions neo4j/v1/direct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

from neo4j.addressing import SocketAddress, resolve
from neo4j.bolt import DEFAULT_PORT, ConnectionPool, connect
from neo4j.exceptions import ServiceUnavailable
from neo4j.v1.api import Driver
from neo4j.v1.security import SecurityPlan
from neo4j.v1.session import BoltSession
Expand All @@ -33,8 +34,14 @@ def __init__(self, connector, address):
self.address = address

def acquire(self, access_mode=None):
resolved_addresses = resolve(self.address)
return self.acquire_direct(resolved_addresses[0])
for address in resolve(self.address):
try:
connection = self.acquire_direct(address) # should always be a resolved address
except ServiceUnavailable:
pass
else:
return connection
raise ServiceUnavailable("Cannot acquire connection to {!r}".format(self.address))


class DirectDriver(Driver):
Expand Down