Skip to content

Conversation

@RagnarW
Copy link
Contributor

@RagnarW RagnarW commented Dec 23, 2015

TCK tests are set to run with runtests.sh

Python-drivers currently do not accept sending Path/Node/Relationship while Java-drivers do. So those tests are currently failing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the random comment here, I just noted that this line will fail on Python3. urllib2 has been renamed urllib (and slightly restructured) there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are probably right. This has currently been build only focusing on python 2.7 at the moment.

@technige
Copy link
Contributor

technige commented Jan 2, 2016

If I understand your description of this PR correctly, I would argue that the Java driver should not permit Node/Rel/Path objects as parameters. Doing so is not supported by the current remoting interface (HTTP) and the behaviour for this is AFAIK not well-defined by Cypher, despite being permitted by the embedded API.

@jakewins: we had conversations about this earlier last year - has this changed?

…or sending

path/node/relationship as parameters since this is not supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason these arguments need to be TitleCased?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. They just have that format in the feature file

technige pushed a commit that referenced this pull request Jan 7, 2016
@technige technige merged commit 14b92fc into 1.0 Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants