Skip to content

Conversation

@technige
Copy link
Contributor

@technige technige commented Mar 3, 2016

Aligned TLS settings with Java driver and completed examples.


# Do not change the contents of this tagged section without good reason*
# tag::minimal-example-import[]
from neo4j.v1 import GraphDatabase, basic_auth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this include basic_auth though? For 99% of first-time users, this import line is what they should use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I'll fix that.

@jakewins
Copy link
Contributor

jakewins commented Mar 4, 2016

Nice! See comments inline, nothing major - but I think we should keep showing the full basic_auth(..) in the examples, and I think we should wait to document trusted certificates until we have a test ensuring the feature works and keeps working.

jakewins added a commit that referenced this pull request Mar 8, 2016
@jakewins jakewins merged commit 27c36d5 into 1.0 Mar 8, 2016
@jakewins jakewins deleted the 1.0-examples branch March 8, 2016 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants