Make result summary only accept known keys #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
force-pushed
the
support-update-flags-in-summary
branch
2 times, most recently
from
0480ffd to
aa42677
Compare
robsdedude
changed the title
`Summary.counters.contains_updates` and `.contains_system_updates` will use the values provided by the server if present. Else, the driver falls back to the previous behavior (computing the values). This PR will also make the driver ignore unknown counter names in the summary- message's 'stats' field.
robsdedude
force-pushed
the
support-update-flags-in-summary
branch
from
452f954 to
c33c60b
Compare
robsdedude
changed the title
robsdedude
force-pushed
the
support-update-flags-in-summary
branch
from
c33c60b to
31c0aeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the result summary would accept any key and use it as an attribute.
This will brake, should the server start to send keys that already exist as
property of the summary object.
Waiting for neo4j-drivers/testkit#268 to be merged. Then re-run TestKit pipeline.