Skip to content

TestKit: Add TLS feature flags #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2021
Merged

TestKit: Add TLS feature flags #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions testkitbackend/requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,12 @@ class FrontendError(Exception):
def load_config():
with open(path.join(path.dirname(__file__), "test_config.json"), "r") as fd:
config = json.load(fd)
return (config["skips"],
[k for k, v in config["features"].items() if v is True])
skips = config["skips"]
features = [k for k, v in config["features"].items() if v is True]
import ssl
if ssl.HAS_TLSv1_3:
features += ["Feature:TLS:1.3"]
return skips, features


SKIPPED_TESTS, FEATURES = load_config()
Expand Down
7 changes: 4 additions & 3 deletions testkitbackend/test_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@
"stub.authorization.test_authorization.TestAuthorizationV4x1.test_should_fail_on_token_expired_on_begin_using_tx_function":
"Flaky: test requires the driver to contact servers in a specific order",
"stub.session_run_parameters.test_session_run_parameters.TestSessionRunParameters.test_empty_query":
"Driver rejects empty queries before sending it to the server",
"tls.tlsversions.TestTlsVersions.test_1_1":
"TLSv1.1 and below are disabled in the driver"
"Driver rejects empty queries before sending it to the server"
},
"features": {
"Feature:API:Result.Single": "Does not raise error when not exactly one record is available. To be fixed in 5.0",
Expand All @@ -35,6 +33,9 @@
"Feature:Auth:Kerberos": true,
"Feature:Bolt:4.4": true,
"Feature:Impersonation": true,
"Feature:TLS:1.1": "Driver blocks TLS 1.1 for security reasons",
"Feature:TLS:1.2": true,
"Feature:TLS:1.3": "Depends on the machine (will be calculated dynamically)",
"AuthorizationExpiredTreatment": true,
"Optimization:ConnectionReuse": true,
"Optimization:EagerTransactionBegin": true,
Expand Down