Skip to content

Editorial changes in warning message and docs. #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Editorial changes in warning message and docs. #920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/api.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,7 +1046,7 @@ See also https://github.com/neo4j/neo4j-python-driver/wiki/preview-features
:Type: :data:`None`, :class:`.Auth` or ``(user, password)``-tuple
:Default: :data:`None` - use the authentication information provided during driver creation.

.. versionadded:: 5.x
.. versionadded:: 5.8


.. _session-notifications-min-severity-ref:
Expand Down
4 changes: 2 additions & 2 deletions src/neo4j/_async/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ def encrypted(self) -> bool:

def _prepare_session_config(self, **config):
if "auth" in config:
preview_warn("User switching is a preview features.",
preview_warn("User switching is a preview feature.",
stack_level=3)
_normalize_notifications_config(config)
return config
Expand Down Expand Up @@ -1165,7 +1165,7 @@ async def supports_session_auth(self) -> bool:
won't throw a :exc:`ConfigurationError` when trying to use this
driver feature.

.. versionadded:: 5.x
.. versionadded:: 5.8
"""
async with self.session() as session:
await session._connect(READ_ACCESS)
Expand Down
4 changes: 2 additions & 2 deletions src/neo4j/_sync/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ def encrypted(self) -> bool:

def _prepare_session_config(self, **config):
if "auth" in config:
preview_warn("User switching is a preview features.",
preview_warn("User switching is a preview feature.",
stack_level=3)
_normalize_notifications_config(config)
return config
Expand Down Expand Up @@ -1164,7 +1164,7 @@ def supports_session_auth(self) -> bool:
won't throw a :exc:`ConfigurationError` when trying to use this
driver feature.

.. versionadded:: 5.x
.. versionadded:: 5.8
"""
with self.session() as session:
session._connect(READ_ACCESS)
Expand Down
2 changes: 1 addition & 1 deletion testkitbackend/_async/requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ async def NewSession(backend, data):
if data.get("authorizationToken"):
config["auth"] = fromtestkit.to_auth_token(data, "authorizationToken")
expected_warnings.append(
(neo4j.PreviewWarning, "User switching is a preview features.")
(neo4j.PreviewWarning, "User switching is a preview feature.")
)
fromtestkit.set_notifications_config(config, data)
if expected_warnings:
Expand Down
2 changes: 1 addition & 1 deletion testkitbackend/_sync/requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ def NewSession(backend, data):
if data.get("authorizationToken"):
config["auth"] = fromtestkit.to_auth_token(data, "authorizationToken")
expected_warnings.append(
(neo4j.PreviewWarning, "User switching is a preview features.")
(neo4j.PreviewWarning, "User switching is a preview feature.")
)
fromtestkit.set_notifications_config(config, data)
if expected_warnings:
Expand Down