Skip to content

Do not drop tablesync replication slots on the publisher #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

Do not drop tablesync replication slots on the publisher #594

merged 1 commit into from
Mar 4, 2025

Conversation

lubennikovaav
Copy link

when we're in the process of dropping subscriptions inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true to know that we're in the Neon-specific process of dropping subscriptions.

tristan957
tristan957 reviewed Mar 4, 2025
View reviewed changes
@lubennikovaav lubennikovaav requested a review from tristan957 March 4, 2025 16:25
tristan957
tristan957 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@tristan957 tristan957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might think about removing the comma from the commit summary.

@lubennikovaav
Do not drop tablesync replication slots on the publisher
915f245 
when we're in the process of dropping subscriptions
inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before
calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true
to know that we're in the Neon-specific process of dropping subscriptions.
@lubennikovaav lubennikovaav force-pushed the fix_drop_sync_slots_v17 branch from fb431df to 915f245 Compare March 4, 2025 21:27
@lubennikovaav lubennikovaav changed the title Do not drop tablesync replication slots on the publisher, Do not drop tablesync replication slots on the publisher Mar 4, 2025
@lubennikovaav lubennikovaav merged commit 780efda into REL_17_STABLE_neon Mar 4, 2025
1 check passed
@lubennikovaav lubennikovaav deleted the fix_drop_sync_slots_v17 branch March 4, 2025 21:50
lubennikovaav added a commit that referenced this pull request May 9, 2025
@lubennikovaav
Skip dropping tablesync replication slots on the publisher (#594)
3866cb1 
when we're in the process of dropping subscriptions
inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before
calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true
to know that we're in the Neon-specific process of dropping subscriptions.
MMeent pushed a commit that referenced this pull request Jul 3, 2025
@lubennikovaav @MMeent
Skip dropping tablesync replication slots on the publisher (#594)
25f53ac 
when we're in the process of dropping subscriptions
inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before
calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true
to know that we're in the Neon-specific process of dropping subscriptions.
MMeent pushed a commit that referenced this pull request Jul 3, 2025
@lubennikovaav @MMeent
Skip dropping tablesync replication slots on the publisher (#594)
29b4880 
when we're in the process of dropping subscriptions
inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before
calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true
to know that we're in the Neon-specific process of dropping subscriptions.
MMeent pushed a commit that referenced this pull request Jul 8, 2025
@lubennikovaav @MMeent
Skip dropping tablesync replication slots on the publisher (#594)
a93aa38 
when we're in the process of dropping subscriptions
inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before
calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true
to know that we're in the Neon-specific process of dropping subscriptions.
MMeent pushed a commit that referenced this pull request Jul 8, 2025
@lubennikovaav @MMeent
Skip dropping tablesync replication slots on the publisher (#594)
786ccb2 
when we're in the process of dropping subscriptions
inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before
calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true
to know that we're in the Neon-specific process of dropping subscriptions.
MMeent pushed a commit that referenced this pull request Jul 11, 2025
@lubennikovaav @MMeent
Skip dropping tablesync replication slots on the publisher (#594)
a4704ac 
when we're in the process of dropping subscriptions
inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before
calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true
to know that we're in the Neon-specific process of dropping subscriptions.
MMeent pushed a commit that referenced this pull request Jul 14, 2025
@lubennikovaav @MMeent
Skip dropping tablesync replication slots on the publisher (#594)
7c0614d 
when we're in the process of dropping subscriptions
inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before
calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true
to know that we're in the Neon-specific process of dropping subscriptions.
MMeent pushed a commit that referenced this pull request Jul 17, 2025
@lubennikovaav @MMeent
Skip dropping tablesync replication slots on the publisher (#594)
c032791 
when we're in the process of dropping subscriptions
inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before
calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true
to know that we're in the Neon-specific process of dropping subscriptions.
MMeent pushed a commit that referenced this pull request Aug 4, 2025
@lubennikovaav
Skip dropping tablesync replication slots on the publisher (#594)
750ac85 
when we're in the process of dropping subscriptions
inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before
calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true
to know that we're in the Neon-specific process of dropping subscriptions.
MMeent pushed a commit that referenced this pull request Aug 6, 2025
@lubennikovaav
Skip dropping tablesync replication slots on the publisher (#594)
6242c42 
when we're in the process of dropping subscriptions
inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before
calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true
to know that we're in the Neon-specific process of dropping subscriptions.
MMeent pushed a commit that referenced this pull request Aug 26, 2025
@lubennikovaav
Skip dropping tablesync replication slots on the publisher (#594)
6fe68e4 
when we're in the process of dropping subscriptions
inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before
calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true
to know that we're in the Neon-specific process of dropping subscriptions.
MMeent pushed a commit that referenced this pull request Sep 2, 2025
@lubennikovaav
Skip dropping tablesync replication slots on the publisher (#594)
494e0c7 
when we're in the process of dropping subscriptions
inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before
calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true
to know that we're in the Neon-specific process of dropping subscriptions.
MMeent pushed a commit that referenced this pull request Sep 15, 2025
@lubennikovaav
Skip dropping tablesync replication slots on the publisher (#594)
1c2ac80 
when we're in the process of dropping subscriptions
inherited by a neon branch.
Because these slots are still needed by the parent branch subscriptions.

For regular slots we handle this by setting the slot_name to NONE before
calling DROP SUBSCRIPTION, but tablesync slots are not exposed to SQL.

rely on GUC disable_logical_replication_subscribers=true
to know that we're in the Neon-specific process of dropping subscriptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tristan957 tristan957 tristan957 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lubennikovaav @tristan957