Skip to content

261 restrict write instruction #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 28, 2021
Merged

261 restrict write instruction #215

merged 22 commits into from
Oct 28, 2021

Conversation

@vakond
Copy link
Contributor

@vakond vakond commented Oct 5, 2021 •
edited
Loading

  • WriteHolder instruction is used instead of Write
  • Holder accounts are created with seed generated with keccak_256 not shake_256

@vakond vakond self-assigned this Oct 5, 2021
vakond added 20 commits October 6, 2021 09:32
@vakond
Merge branch 'develop' into 261-restrict-write-instruction
9bb1924
@vakond
Use WriteHolder (15=0x0F) instead of Write (0) (261-restrict-write-in…
9e8a545 
…struction)
@vakond
Merge branch 'develop' into 261-restrict-write-instruction
28f1e5d
@vakond
Merge develop (261-restrict-write-instruction)
d861d55
@vakond
WriteHolder index: 15 => 16 (261-restrict-write-instruction)
4abbda5
@vakond
Merge branch 'develop' into 261-restrict-write-instruction
9913c0d
@vakond
Merge branch 'develop' into 261-restrict-write-instruction
58f5851
@vakond
Merge branch 'develop' into 261-restrict-write-instruction
68ac29a
@vakond
WriteHolder index: 16 => 17 (261-restrict-write-instruction)
f60eee9
@vakond
Merge branch 'develop' into 261-restrict-write-instruction
4888344
@vakond
WriteHolder index: 17 => 18 (261-restrict-write-instruction)
8c96419
@vakond
WriteHolder instruction creates bigger trx due to seed (261-restrict-…
a5bbb43 
…write-instruction)
@vakond
WriteHolder instruction creates bigger trx due to seed (261-restrict-…
27eac90 
…write-instruction)
@vakond
Comment unneeded logging (261-restrict-write-instruction)
1472ae3
@vakond
bugfix (261-restrict-write-instruction)
f8edc4b
@vakond
Merge branch 'develop' into 261-restrict-write-instruction
c9a0bbb
@vakond
Refactor WriteHolder from seed to nonce (261-restrict-write-instruction)
04d706c
@vakond
Merge branch 'develop' into 261-restrict-write-instruction
a02a789
@vakond
Merge branch 'develop' into 261-restrict-write-instruction
54ec920
@vakond
Exclude signer pubkey from seed generation (261-restrict-write-instru…
2eabd94 
…ction)
s-medvedev
s-medvedev reviewed Oct 28, 2021
View reviewed changes
@s-medvedev s-medvedev merged commit 2aa4072 into develop Oct 28, 2021
@s-medvedev s-medvedev deleted the 261-restrict-write-instruction branch October 28, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anton-lisanin anton-lisanin Awaiting requested review from anton-lisanin

@otselnik otselnik Awaiting requested review from otselnik

1 more reviewer

@s-medvedev s-medvedev s-medvedev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vakond vakond

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vakond @s-medvedev