BUGFIX: URL encode username, password and host in MailerService::createDsnFromSMTPSwiftMailerConfiguration() #4
Conversation
bwaidelich
left a comment
bwaidelich
left a comment
There was a problem hiding this comment.
Thanks!
Just wondering: Is it documented somewhere that URL encoding is the right solution for this?
|
The Symfony Mailer Docs also mention this. Warning If the username, password or host contain any character considered special in a URI (such as : / ? # [ ] @ ! $ & ' ( ) * + , ; =), you must encode them. See RFC 3986 for the full list of reserved characters or use the urlencode function to encode them. But thanks for your hint. I think we need to urlencode the domain, too. |
If the old SwiftMailer configuration had some special chars in their username like @, # or other special chars, the migrated DSN will be invalid. This leads to DSNs that will not work and show an error. To prevent this, all special chars in username and passwort are now urlencoded. Fixes neos#2
Benjamin-K
force-pushed
the
fix/dsn-migration
branch
from
576f968 to
18f87ac
Compare
|
Added |
bwaidelich
left a comment
bwaidelich
left a comment
There was a problem hiding this comment.
Awesome, thx for the context. +1 by reading
Benjamin-K
changed the title
|
@markusguenther Would you like to merge this and create a new version? |
|
@Benjamin-K Hey, thanks for this input and fix. Will take care tomorrow :) |
markusguenther
changed the title
3 participants
If the old SwiftMailer configuration had some special chars in their username like @, # or other special chars, the migrated DSN will be invalid. This leads to DSNs that will not work and show an error. To prevent this, all special chars in username and passwort are now urlencoded.
Fixes #2