Support Go module #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
reviewed
May 16, 2019
go.mod
Outdated
| @@ -0,0 +1,3 @@ | |||
| module github.com/neovim/go-client | |||
|
|
|||
| go 1.12 | |||
There was a problem hiding this comment.
I don't see this in https://github.com/golang/go/wiki/Modules#example . Does this mean we require 1.12? Should it be 1.11 instead?
Do we need a require() section?
There was a problem hiding this comment.
just remove go 1.12.
Do we need a require() section?
The require() section needs if this repo(package) depends on another third-party package.
neovim/go-client written in only Go standard package. In this case, we don't need a require section.
|
@justinmk commented and rebased. PTAL. |
justinmk
approved these changes
May 16, 2019
|
@justinmk I'll bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Go Module.
As I said before, needs adding
go.mod. Just added and fix travis test config.