Window tearing

[WhiteBlackGoose]

Neovim version (nvim -v)

Commit: 035d41a

Vim (not Nvim) behaves the same?

not applicable

Operating system/version

debian 12

Terminal name/version

terminator 2.1.2

$TERM environment variable

xterm-256color

Installation

Sources 035d41a

How to reproduce the issue

I'm not sure how to minimally reproduce it, but I use my fork of a great plugin. Before this commit, it worked well, after - it started window tearing (like appearing and hiding all the time).

So to repro

1. Get that plugin
2. :MagmaInit python3 (or any other kernel)
3. Select text 1+1 and run :MagmaEvaluateVisual

Not the best reproduction but I'll try to fix it myself, I hope.

Expected behavior

Shows a window

Actual behavior

The window keeps appearing/disappearing, like screen tearing

[WhiteBlackGoose]

git bisect log

git bisect start
# status: waiting for both good and bad commits
# good: [e8c94697bcbe23a5c7b07c292b90a6b70aadfa87] ci: test only a single macos version (#19418)
git bisect good e8c94697bcbe23a5c7b07c292b90a6b70aadfa87
# status: waiting for bad commit, 1 good commit known
# bad: [393cffc1f85dfbd0fb1d69f67ac8a746373e6425] no need for cron
git bisect bad 393cffc1f85dfbd0fb1d69f67ac8a746373e6425
# good: [c7cf1232a71b0db700b818e2ae8e8ebaf40133f2] vim-patch:8.2.4467: running filetype test leaves file behind (#20335)
git bisect good c7cf1232a71b0db700b818e2ae8e8ebaf40133f2
# good: [20bd4d89977005845c070cde9df75496f948fa1e] vim-patch:9.0.0823: mouse drag test fails
git bisect good 20bd4d89977005845c070cde9df75496f948fa1e
# good: [211c568e6452e62b119ac4b987ff47b9174ec9ad] test: don't skip parser_spec on windows (#20294)
git bisect good 211c568e6452e62b119ac4b987ff47b9174ec9ad
# bad: [26cba0b17d2e04ca48f737906e3c7ba19af59cdc] Merge pull request #21080 from folke/fix_multigrid_lua_ui_attach
git bisect bad 26cba0b17d2e04ca48f737906e3c7ba19af59cdc
# good: [cf759c7429c6b81adbbd6ffd93d80131b608cebc] Merge pull request #21102 from zeertzjq/vim-8.2.4512
git bisect good cf759c7429c6b81adbbd6ffd93d80131b608cebc
# bad: [904d0056d520ef01e2873bbaa91a4693e8dfd226] fix(diagnostic): correct type annotations; add Diagnostic type (#21120)
git bisect bad 904d0056d520ef01e2873bbaa91a4693e8dfd226
# good: [7c57f06b63f7c4e3b62a765b7b7814ef017a602d] vim-patch:partial:d13166e788fc (#21109)
git bisect good 7c57f06b63f7c4e3b62a765b7b7814ef017a602d
# bad: [91c192922da0240be5a8eb4045dae6cd968957e9] vim-patch:9.0.0915: WinScrolled may trigger immediately when defined
git bisect bad 91c192922da0240be5a8eb4045dae6cd968957e9
# good: [6e8ed5abaa9c33d1d78ab7ff5b07dd5bac623a1d] perf(diagnostic): use api variable and improve validate (#21111)
git bisect good 6e8ed5abaa9c33d1d78ab7ff5b07dd5bac623a1d
# good: [822eabc5e123bca71ba945467c3b01110bb0e003] docs(support): update tested versions (#21126)
git bisect good 822eabc5e123bca71ba945467c3b01110bb0e003
# bad: [035d41ac5e5fcbb49eb64b72a924c4d6f89f0579] vim-patch:partial:9.0.0913: only change in current window triggers the WinScrolled event
git bisect bad 035d41ac5e5fcbb49eb64b72a924c4d6f89f0579
# first bad commit: [035d41ac5e5fcbb49eb64b72a924c4d6f89f0579] vim-patch:partial:9.0.0913: only change in current window triggers the WinScrolled event

[zeertzjq]

Can you check if applying this diff to src/nvim/window.c fixes the problem:

diff --git a/src/nvim/window.c b/src/nvim/window.c
index 1f80f14f2..004aa4a20 100644
--- a/src/nvim/window.c
+++ b/src/nvim/window.c
@@ -5398,6 +5398,10 @@ static int check_window_scroll_resize(int *size_count, win_T **first_scroll_win,
   int tot_skipcol = 0;
 
   FOR_ALL_WINDOWS_IN_TAB(wp, curtab) {
+    if (wp->w_last_topline == 0) {
+      continue;
+    }
+
     const bool size_changed = wp->w_last_width != wp->w_width
                               || wp->w_last_height != wp->w_height;
     if (size_changed) {

[WhiteBlackGoose]

Yes, it fixes! Thanks.

Would you like me to submit a PR with it or you're going to do it yourself?

[zeertzjq]

I'll do it later.

[zeertzjq]

I went for a less drastic solution in #21333. Does that PR also fix the problem?

[zeertzjq]

I went for a less drastic solution in #21333. Does that PR also fix the problem?

@WhiteBlackGoose

[WhiteBlackGoose]

Sorry, will check soon, was busy a bit

[WhiteBlackGoose]

I'm trying to reproduce the issue on your fork -1 commit, but there's no such behavior on zeertzjq/winscrolled-float~1

[zeertzjq]

Or you can just revert the previous diff and apply this one:

diff --git a/src/nvim/window.c b/src/nvim/window.c
index 75320bcb7d3c0..05694a8b6df5c 100644
--- a/src/nvim/window.c
+++ b/src/nvim/window.c
@@ -5405,6 +5405,18 @@ static int check_window_scroll_resize(int *size_count, win_T **first_scroll_win,
   int tot_skipcol = 0;
 
   FOR_ALL_WINDOWS_IN_TAB(wp, curtab) {
+    // Skip floating windows that do not have a snapshot (usually becuase they are newly-created),
+    // as unlike split windows, creating floating windows do not cause other windows to resize.
+    if (wp->w_floating && wp->w_last_topline == 0) {
+      wp->w_last_topline = wp->w_topline;
+      wp->w_last_topfill = wp->w_topfill;
+      wp->w_last_leftcol = wp->w_leftcol;
+      wp->w_last_skipcol = wp->w_skipcol;
+      wp->w_last_width = wp->w_width;
+      wp->w_last_height = wp->w_height;
+      continue;
+    }
+
     const bool size_changed = wp->w_last_width != wp->w_width
                               || wp->w_last_height != wp->w_height;
     if (size_changed) {

[WhiteBlackGoose]

Sure, but I want a clean repro before I see the changes of your commit. One second

[WhiteBlackGoose]

Damn... can't even reproduce on the commit from the issue. I guess there's some non-clean state