added new baseline #262
Merged
added new baseline #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for porch-docs-refactor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/lgtm |
|
How much do we want to keep the links correct here? I think it is needed at the end that all the links are correct, but I do not want to be the links to be a blocker to start the work. |
liamfallon
approved these changes
Oct 6, 2025
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
Signed-off-by: Michael Greaves <michael.greaves@nokia.com> Co-authored-by: Catalin Stratulat <159934629+Catalin-Stratulat-Ericsson@users.noreply.github.com>
…nce npm scripts (nephio-project#256) This pull request introduces a series of improvements to the documentation repository, focusing on correcting configuration metadata, upgrading core dependencies, and enhancing the developer workflow. These changes address technical debt and align the project with modern best practices. ### Key Changes: **1. `package.json` Overhaul:** - **Fixed Typo:** Corrected the package name in `name` field from `nephio-rpoject-docs` to `nephio-project-docs`. - **Aligned License:** Updated the `license` field from `APACHE2` to `CC-BY-4.0` to match the repository's `LICENSE` file. - **Added Description:** Populated the empty `description` field with a clear and concise project summary. - **Enhanced Discoverability:** Added relevant keywords to the `keywords` array. - **Implemented npm Scripts:** Introduced a standard set of scripts for better workflow automation: - `build`: For production builds (`hugo --gc --minify`). - `serve`: For local development (`hugo server -D`). - `lint`: For running quality checks. - `test`: An alias for the `lint` script. **2. Core Dependency Upgrades:** - **Hugo & Go:** Upgraded `HUGO_VERSION` to `0.148.2` and `GO_VERSION` to `1.24.5` in `netlify.toml` and `go.mod` to leverage the latest features, performance improvements, and security patches. - **Docsy Theme:** Updated the Docsy theme requirement to `v0.12.0` in `go.mod`. - Ran `go mod tidy` to ensure all dependencies are consistent. **3. Code Cleanup:** - **Removed Redundancy:** Deleted a duplicate `!include` statement in `diagrams/src/level3-nephio-porch-component.puml` to fix the diagram definition. These changes collectively improve the project's maintainability, security, and developer experience. Signed-off-by: Hsiu-Chi Tsai <[84045975+thc1006@users.noreply.github.com](mailto:84045975+thc1006@users.noreply.github.com) >"
|
New changes are detected. LGTM label has been removed. |
|
lapentad
reviewed
Oct 10, 2025
|
|
||
| {{% alert title="Note" color="primary" %}} | ||
|
|
||
| Installation of Porch, including its prerequisites, is covered in a [dedicated document](install-porch.md). |
There was a problem hiding this comment.
Suggested change
| Installation of Porch, including its prerequisites, is covered in a [dedicated document](install-porch.md). | |
| Installation of Porch, including its prerequisites, is covered in a [dedicated document](./install-porch.md). |
lapentad
reviewed
Oct 10, 2025
|
|
||
| The porch server handles interaction with associated git repositories through the use of porch repository CR (Custom Resource) which act as a link between the porch server and the git repositories the server is meant to interact with and store packages on. | ||
|
|
||
| More information on porch repositories can be found [here](../package-orchestration.md#repositories). |
There was a problem hiding this comment.
Suggested change
| More information on porch repositories can be found [here](../package-orchestration.md#repositories). | |
| More information on porch repositories can be found [here](../../porch/package-orchestration.md#repositories). |
lapentad
reviewed
Oct 10, 2025
Comment on lines
+86
to
+89
| * [Configuration as Data](https://docs.nephio.org/docs/porch/concepts/configuration-as-data/) | ||
| * [Package Mutation Pipeline Order](https://docs.nephio.org/docs/porch/concepts/package-mutation-pipeline/) | ||
| * [Function Runner Pod Templating](https://docs.nephio.org/docs/porch/concepts/function-runner/) | ||
| * [Package Variant Controller](https://docs.nephio.org/docs/porch/concepts/variant-controller/) |
There was a problem hiding this comment.
Suggested change
| * [Configuration as Data](https://docs.nephio.org/docs/porch/concepts/configuration-as-data/) | |
| * [Package Mutation Pipeline Order](https://docs.nephio.org/docs/porch/concepts/package-mutation-pipeline/) | |
| * [Function Runner Pod Templating](https://docs.nephio.org/docs/porch/concepts/function-runner/) | |
| * [Package Variant Controller](https://docs.nephio.org/docs/porch/concepts/variant-controller/) | |
| <!--- TODO: replace with published links --> | |
| * [Configuration as Data](https://docs.nephio.org/docs/porch/) | |
| <!--- https://docs.nephio.org/docs/porch/concepts/configuration-as-data/ --> | |
| * [Package Mutation Pipeline Order](https://docs.nephio.org/docs/porch/) | |
| <!--- https://docs.nephio.org/docs/porch/concepts/package-mutation-pipeline/ --> | |
| * [Function Runner Pod Templating](https://docs.nephio.org/docs/porch/) | |
| <!--- https://docs.nephio.org/docs/porch/concepts/function-runner/ --> | |
| * [Package Variant Controller](https://docs.nephio.org/docs/porch/) | |
| <!--- https://docs.nephio.org/docs/porch/concepts/variant-controller/ --> |
efiacor
merged commit 76debfc
into
nephio-project:porch-docs-refactor
7 of 9 checks passed
lapentad
pushed a commit
to Nordix/nephio-docs
that referenced
this pull request
Oct 17, 2025
new baseline to work off of --------- Signed-off-by: Michael Greaves <michael.greaves@nokia.com> Signed-off-by: Hsiu-Chi Tsai Co-authored-by: mpgreaves <103421482+mpgreaves@users.noreply.github.com> Co-authored-by: 蔡秀吉 <84045975+thc1006@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new baseline to work off of